Uh oh!
There was an error while loading. Please reload this page.
feat: Unify TextInput autoComplete and textContentType props - #34523
feat: Unify TextInput autoComplete and textContentType props#34523gabrieldonadel wants to merge 4 commits into
Conversation
Base commit: b6bf1fd |
Base commit: b6bf1fd |
facebook-github-bot
commented
Aug 29, 2022
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
6e8761d to
21ba83aCompare21ba83a to
22b7359Comparefacebook-github-bot
commented
Aug 30, 2022
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gabrieldonadel
commented
Sep 5, 2022
@necolas do you mind checking what is causing internal builds and tests to fail? |
necolas
commented
Sep 5, 2022
Someone else will have to import this PR. I closed that internal diff as I'm away for the rest of September |
necolas
commented
Sep 6, 2022
Ping @cipolleschi or @jacdebug to import |
facebook-github-bot
commented
Sep 7, 2022
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| } | ||
| autoComplete={ | ||
| Platform.OS === 'android' | ||
| ? // $FlowFixMe |
There was a problem hiding this comment.
What is this suppressing? If we do add a suppression, could we suppress the specific error?
There was a problem hiding this comment.
Hi @NickGerleman this is suppressing the prop-missing error because the autoCompleteWebToAutoCompleteAndroidMap object does not include all autoComplete keys/values. The reason for this is just because it would make the object super huge and we can just fallback to autoComplete when autoCompleteWebToTextContentTypeMap[autoComplete] is undefined. I've just updated the suppression to specify the prop-missing error tho
react-native-bot
commented
Sep 8, 2022
This pull request was successfully merged by @gabrieldonadel in 73abcba. When will my fix make it into a release? | Upcoming Releases |
Summary
This unifies the Android only
autoCompleteand the iOS onlytextContentTypeTextInput props with the webautoCompletevalues as requested on #34424. I left thetextContentTypeprop and the current supportedautoCompletevalues untouched in order to avoid having a breaking change. This also updates RNTester to include test cases using the newautoCompletevaluesChangelog
[General] [Changed] - Unify TextInput autoComplete and textContentType props
Test Plan
TextInputcomponent through theText Auto CompletesectionScreen.Recording.2022-08-29.at.00.37.52.mov