Uh oh!
There was an error while loading. Please reload this page.
feat: Add tintColor prop to Image component - #34534
Conversation
Base commit: 10ea6fb |
facebook-github-bot
commented
Aug 30, 2022
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 10ea6fb |
| import type {EdgeInsetsProp} from '../StyleSheet/EdgeInsetsPropType'; | ||
| import type {ImageSource} from './ImageSource'; | ||
| import type {ViewStyleProp, ImageStyleProp} from '../StyleSheet/StyleSheet'; | ||
| import type {____ColorValue_Internal} from '../StyleSheet/StyleSheetTypes'; |
There was a problem hiding this comment.
I think we'll want to import the type like this: https://github.com/facebook/react-native/blob/d7921f05048c9163d7d2c102e5226abf59d88948/Libraries/StyleSheet/PlatformColorValueTypes.ios.js#L11
There was a problem hiding this comment.
Good point, I've just updated it.
facebook-github-bot
commented
Aug 31, 2022
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Aug 31, 2022
This pull request was successfully merged by @gabrieldonadel in 7a6f0e4. When will my fix make it into a release? | Upcoming Releases |
Summary
This adds the
tintColorprop to the Image component to replace the non-standardstyle.tintColoras requested on #34424, so that React Native for Web does not have to deopt styles for Image rendering. I didn't have to change anything on Android astintColorwas already being passed down to the native component as a prop. This PR also updates RNTester ImageExample in order to facilitate the manual QA.Changelog
[General] [Added] - Add tintColor prop to Image component
Test Plan
tintColorprop through theTint ColorsectionScreen.Recording.2022-08-30.at.10.07.40.mov