feat: added accessibility value aliases by dakshbhardwaj · Pull Request #34535 · react/react-native

dakshbhardwaj · 2022-08-30T15:10:47Z

Summary

This adds aliasing for accessibility Value, it's used as requested on #34424.

aria-valuemax to equivalent accessibilityValue.max
aria-valuemin to equivalent accessibilityValue.min
aria-valuenow to equivalent accessibilityValue.now
aria-valuetext to equivalent accessibilityValue.text

Changelog

[General] [Added] - Add aria-valuemax, aria-valuemin, aria-valuenow, aria-valuetext as alias prop to TouchableOpacity, View, PressableTouchableHighlightTouchableBounceTouchableWithoutFeedbackTouchableOpacity components

Test Plan

Enable talkback.
Open the RNTester app and navigate to the Api's tab
Go to the fake Slider Example for Accessibility Value modes section

analysis-bot · 2022-08-30T15:35:42Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,640,076	-1,366
android	hermes	armeabi-v7a	7,052,425	-1,309
android	hermes	x86	7,941,824	-1,341
android	hermes	x86_64	7,913,752	-1,473
android	jsc	arm64-v8a	9,514,674	-48
android	jsc	armeabi-v7a	8,290,285	-46
android	jsc	x86	9,454,000	-51
android	jsc	x86_64	10,045,066	-53

Base commit: 5e1c4d4
Branch: main

analysis-bot · 2022-08-30T16:40:24Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 5e1c4d4
Branch: main

jacdebug · 2022-08-30T16:48:06Z

Thanks for working on this, could you please have a look on failing test @dakshbhardwaj

dakshbhardwaj · 2022-09-01T08:50:05Z

Thanks for working on this, could you please have a look on failing test @dakshbhardwaj

@jacdebug I have updated my PR

facebook-github-bot · 2022-09-01T11:05:03Z

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-09-08T10:07:07Z

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jacdebug

Sorry for late review, please see inline comment for changes requested.

jacdebug · 2022-09-08T10:20:02Z

+ text:
+ props['aria-valuetext'] !== null
+ ? props['aria-valuetext']
+ : props.accessibilityValue?.max,


Suggested change
: props.accessibilityValue?.max,
: props.accessibilityValue?.text,

jacdebug · 2022-09-08T10:20:14Z

+ text:
+ this.props['aria-valuetext'] !== null
+ ? this.props['aria-valuetext']
+ : this.props.accessibilityValue?.max,


Suggested change
: this.props.accessibilityValue?.max,
: this.props.accessibilityValue?.text,

jacdebug · 2022-09-08T10:20:24Z

+ text:
+ this.props['aria-valuetext'] !== null
+ ? this.props['aria-valuetext']
+ : this.props.accessibilityValue?.max,


Suggested change
: this.props.accessibilityValue?.max,
: this.props.accessibilityValue?.text,

jacdebug · 2022-09-08T10:20:36Z

+ text:
+ this.props['aria-valuetext'] !== null
+ ? this.props['aria-valuetext']
+ : this.props.accessibilityValue?.max,


Suggested change
: this.props.accessibilityValue?.max,
: this.props.accessibilityValue?.text,

jacdebug · 2022-09-08T10:20:49Z

+ text:
+ this.props['aria-valuetext'] !== null
+ ? this.props['aria-valuetext']
+ : this.props.accessibilityValue?.max,


Suggested change
: this.props.accessibilityValue?.max,
: this.props.accessibilityValue?.text,

dakshbhardwaj · 2022-09-08T12:46:47Z

Sorry for late review, please see inline comment for changes requested.

@jacdebug Thanks for the review, I have pushed down the review changes

facebook-github-bot · 2022-09-08T15:45:45Z

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jacdebug

One more left

Co-authored-by: jacdebug <jacob.deepak@yahoo.com>

dakshbhardwaj · 2022-09-08T16:30:57Z

One more left

@jacdebug pushed the changes

facebook-github-bot · 2022-09-08T16:44:31Z

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jacdebug · 2022-09-08T17:18:47Z

there are some new conflicts @dakshbhardwaj

dakshbhardwaj · 2022-09-08T17:31:10Z

there are some new conflicts @dakshbhardwaj

@jacdebug I have resolved the conflicts

facebook-github-bot · 2022-09-08T17:40:22Z

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jacdebug

Please see inline commend use nullish coalescing operator is correct and make code more readable.

jacdebug · 2022-09-09T07:51:11Z

+ max:
+ props['aria-valuemax'] !== null
+ ? props['aria-valuemax']
+ : props.accessibilityValue?.max,


Suggested change
max:
props['aria-valuemax']!==null
? props['aria-valuemax']
: props.accessibilityValue?.max,
max: props['aria-valuemax']??props.accessibilityValue?.max,
This is more accurate and simple, please update the change for rest of properties on all changed files.

dakshbhardwaj · 2022-09-09T08:35:04Z

Please see inline commend use nullish coalescing operator is correct and make code more readable.

@jacdebug I have made the changes

facebook-github-bot · 2022-09-09T09:17:54Z

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-09-09T11:55:05Z

This pull request was successfully merged by @dakshbhardwaj in e8739e9.

^{When will my fix make it into a release? | Upcoming Releases}

feat: added accessibility value alias
28266c4

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 30, 2022

react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Aug 30, 2022

docs changes
e57536f

necolas mentioned this pull request Aug 31, 2022
[w3c] ☂️ Web Props (Part 1) umbrella issue #34424
Closed
70 tasks

updated the snapshots for failing testcases
ec39394

Daksh Bhardwaj added 6 commits September 1, 2022 23:43

Merge branch 'facebook:main' into daksh/add-accessibility-value
78a5094

Merge branch 'facebook:main' into daksh/add-accessibility-value
9560307

Merge branch 'facebook:main' into daksh/add-accessibility-value
b284db5

Merge branch 'main' into daksh/add-accessibility-value
56bd3cf

Merge branch 'main' into daksh/add-accessibility-value
46c70d8

Merge branch 'main' into daksh/add-accessibility-value
cb105cb

jacdebug requested changes Sep 8, 2022
View reviewed changes

Daksh Bhardwaj added 2 commits September 8, 2022 17:02

Merge branch 'main' into daksh/add-accessibility-value
93053fd

pr review changes
6c7fb7e

jacdebug requested changes Sep 8, 2022
View reviewed changes

Comment threadLibraries/Components/Pressable/Pressable.js Outdated

Update Libraries/Components/Pressable/Pressable.js
410727e
Co-authored-by: jacdebug <jacob.deepak@yahoo.com>

Merge branch 'main' into daksh/add-accessibility-value
41d2125

removed linting issue
7fbb627

jacdebug added the Needs TypeScript Update label Sep 8, 2022

jacdebug requested changes Sep 9, 2022
View reviewed changes

added nullish coalescing operaor
cdbc72f

jacdebug approved these changes Sep 9, 2022
View reviewed changes

facebook-github-bot closed this in e8739e9Sep 9, 2022

react-native-bot added the Merged This PR has been merged. label Sep 9, 2022

coderabbitaiBot mentioned this pull request Aug 22, 2026
[Feature]: Add CustomSpinner to the design system and migrate every ActivityIndicator onto it timothyrusso/HolidAI#472
Merged

	: props.accessibilityValue?.max,
	: props.accessibilityValue?.text,

	: this.props.accessibilityValue?.max,
	: this.props.accessibilityValue?.text,

Uh oh!

Conversation

dakshbhardwaj commented Aug 30, 2022

Summary

Changelog

Test Plan

Uh oh!

analysis-bot commented Aug 30, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Aug 30, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacdebug commented Aug 30, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dakshbhardwaj commented Sep 1, 2022

Uh oh!

facebook-github-bot commented Sep 1, 2022

Uh oh!

facebook-github-bot commented Sep 8, 2022

Uh oh!

jacdebug left a comment

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 8, 2022

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 8, 2022

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 8, 2022

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 8, 2022

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dakshbhardwaj commented Sep 8, 2022

Uh oh!

facebook-github-bot commented Sep 8, 2022

Uh oh!

jacdebug left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dakshbhardwaj commented Sep 8, 2022

Uh oh!

facebook-github-bot commented Sep 8, 2022

Uh oh!

jacdebug commented Sep 8, 2022

Uh oh!

dakshbhardwaj commented Sep 8, 2022

Uh oh!

facebook-github-bot commented Sep 8, 2022

Uh oh!

jacdebug left a comment

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 9, 2022

Choose a reason for hiding this comment

Uh oh!

dakshbhardwaj commented Sep 9, 2022

Uh oh!

facebook-github-bot commented Sep 9, 2022

Uh oh!

react-native-bot commented Sep 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

analysis-bot commented Aug 30, 2022•
edited
Loading

analysis-bot commented Aug 30, 2022•
edited
Loading

jacdebug commented Aug 30, 2022•
edited
Loading