Uh oh!
There was an error while loading. Please reload this page.
Feat/role to accessibility role mapping - #34538
Conversation
facebook-github-bot
commented
Aug 30, 2022
Hi @madhav23bansal! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
madhav23bansal
commented
Aug 30, 2022
Hi @necolas, I have added mapping as given in the examples, but I was a bit confused about the mapping of roles that exist on the web but do not exist on react native. |
Uh oh!
There was an error while loading. Please reload this page.
Base commit: 5c109b3 |
facebook-github-bot
commented
Aug 30, 2022
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
commented
Aug 30, 2022
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Base commit: 5c109b3 |
necolas
commented
Aug 30, 2022
I think the flow type should allow all the values supported on web. We just don't forward unsupported values to the inner component |
madhav23bansal
commented
Aug 30, 2022
Hi @necolas, I have added all the roles supported on the web, just have not mapped them to View. |
Uh oh!
There was an error while loading. Please reload this page.
facebook-github-bot
commented
Aug 31, 2022
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
necolas
commented
Aug 31, 2022
Thank you for all the follow-ups @madhav23bansal |
facebook-github-bot
commented
Sep 5, 2022
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Sep 5, 2022
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Sep 5, 2022
This pull request was successfully merged by @madhav23bansal in a50e6fb. When will my fix make it into a release? | Upcoming Releases |
Summary
This adds role alias for accessibilityRole, it unifies role and accessibilityRole as requested on #34424
Changelog
[General][Added] - Added role alias for accessibilityRole.
Test Plan