Uh oh!
There was an error while loading. Please reload this page.
feat: Add support for verticalAlign style - #34567
Conversation
9334f1b to
85b4b4dCompare
Base commit: 2319f75 |
Uh oh!
There was an error while loading. Please reload this page.
Base commit: 2319f75 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
2e56d42 to
6c53112Comparenecolas
commented
Sep 12, 2022
Sorry, this needs someone from Meta to import the PR |
gabrieldonadel
commented
Sep 23, 2022
@cipolleschi@cortinico would you mind importing this? |
facebook-github-bot
commented
Sep 23, 2022
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
commented
Sep 23, 2022
Sorry, I missed it! But now it has been imported. |
cipolleschi
commented
Sep 26, 2022
Hi @gabrieldonadel, thanks for all your work with these PRs. We recently started to maintain the TypeScript types and it looks like that this PR touches the Flow types in the StyleSheetTypes.js. Could you update also the TypeScript definitions in this file? |
gabrieldonadel
commented
Sep 26, 2022
Hi @cipolleschi, thanks for reviewing this, I've just pushed a commit updating TS types |
6c53112 to
d06dafcCompare
|
cipolleschi
commented
Sep 26, 2022
Thanks for the update! :D Could you also take care of the lint errors, please? 🙏 |
d06dafc to
3be099eComparegabrieldonadel
commented
Sep 27, 2022
@cipolleschi I believe there is some problem with the Danger configuration, all these warnings are about |
cipolleschi
commented
Sep 28, 2022
Could you rebase on |
gabrieldonadel
commented
Sep 28, 2022
Sure, done |
3be099e to
d0d6076Comparefacebook-github-bot
commented
Sep 30, 2022
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
c8a4515 to
71352dcComparefacebook-github-bot
commented
Oct 3, 2022
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
13 similar comments
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
commented
Oct 3, 2022
This pull request was successfully merged by @gabrieldonadel in 32b6f31. When will my fix make it into a release? | Upcoming Releases |
Summary
This adds support for the
verticalAlignstyle attribute, mapping the already existingtextAlignVerticalattribute as requested on #34425. This PR also updates the TextExample.android on the RNTester in order to facilitate the manual QA of this.Changelog
[Android] [Added] - Add support for verticalAlign style
Test Plan
Text alignmentsectionScreen.Recording.2022-09-02.at.00.16.12.mov