Skip to content

chore: rename polyfills to js-polyfills (umbrella 480) - #34574

Closed
Titozzz wants to merge 4 commits into
react:mainfrom
Titozzz:chore-480-rename-polyfills
Closed

chore: rename polyfills to js-polyfills (umbrella 480)#34574
Titozzz wants to merge 4 commits into
react:mainfrom
Titozzz:chore-480-rename-polyfills

Conversation

@Titozzz

Copy link
Copy Markdown
Collaborator

Summary

Changelog

[General] [Changed] - Rename polyfills to js-polyfills as part of react-native-community/discussions-and-proposals#480

Test Plan

@Titozzz
Titozzz requested a review from hramos as a code ownerSeptember 2, 2022 09:40
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2022
@github-actions

github-actionsBot commented Sep 2, 2022

Copy link
Copy Markdown
Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 04943ae

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022
@analysis-bot

analysis-bot commented Sep 2, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,103,561+0
androidhermesarmeabi-v7a6,471,886+0
androidhermesx867,521,203+0
androidhermesx86_647,380,081+0
androidjscarm64-v8a8,968,399+0
androidjscarmeabi-v7a7,699,505+0
androidjscx869,030,706+0
androidjscx86_649,508,749+0

Base commit: 2d1d61a
Branch: main

@analysis-bot

analysis-bot commented Sep 2, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 2d1d61a
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kelsetkelset added the Tech: Monorepo For PRs that are related to the monorepo infra label Sep 12, 2022
@cortinicocortinico mentioned this pull request Sep 14, 2022
11 tasks
Comment threadpackages/js-polyfills/BUCK Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting here but valid for the whole PR:

Let's undo the BUCK update and the path change. It will make easier for us to import and merge this change 👍

I've also posted an update on the monorepo effort there:

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

Comment threadBUCK Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted

Comment threadpackages/js-polyfills/package.json Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted, alognisde the path renaming

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi

Copy link
Copy Markdown
Contributor

/rebase

@cortinico

Copy link
Copy Markdown
Contributor

@Titozzz can you manually rebase this. We can't use /rebase here as this is older

@hoxyq

Copy link
Copy Markdown
Contributor

Hey @Titozzz,

Thanks for working on this, I am now planning to continue your work this and #34571 PRs. There are some changes that we need to introduce before merging this.

Could you please share if this is okay for you?

@Titozzz

Copy link
Copy Markdown
CollaboratorAuthor

@hoxyq do what you have to do 👍 lmk if I can help

@hoxyq
hoxyqforce-pushed the chore-480-rename-polyfills branch from 75c946c to 57cb25bCompareNovember 25, 2022 12:52
@hoxyq
hoxyqforce-pushed the chore-480-rename-polyfills branch from 57cb25b to 04943aeCompareNovember 25, 2022 12:57
@pull-bot

Copy link
Copy Markdown

PR build artifact for 04943ae is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for 04943ae is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Titozzz in ca1ae5c.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Nov 26, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been reverted by 6e9d3bf.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.RevertedShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Tech: MonorepoFor PRs that are related to the monorepo infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Titozzz@analysis-bot@facebook-github-bot@cipolleschi@cortinico@hoxyq@pull-bot@react-native-bot@kelset