Uh oh!
There was an error while loading. Please reload this page.
feat: Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>. - #34576
Closed
gedeagas wants to merge 5 commits into
Closed
feat: Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>.#34576gedeagas wants to merge 5 commits into
gedeagas wants to merge 5 commits into
Conversation
gedeagas
commented
Sep 2, 2022
ContributorAuthor
Task Umbrella |
74 tasks
Base commit: 12e5842 |
Base commit: 12e5842 |
necolas
reviewed
Sep 2, 2022
Uh oh!
There was an error while loading. Please reload this page.
necolas
reviewed
Sep 2, 2022
Uh oh!
There was an error while loading. Please reload this page.
gedeagas
commented
Sep 5, 2022
ContributorAuthor
Resolved, please re review @necolas |
necolas
approved these changes
Sep 5, 2022
gedeagas
commented
Sep 5, 2022
ContributorAuthor
necolas
commented
Sep 5, 2022
No, this is the first PR and the one we focused on. Close the other one |
facebook-github-bot
commented
Sep 5, 2022
Contributor
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Sep 8, 2022
Collaborator
This pull request was successfully merged by @gedeagas in b2452ab. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to add support for objectFit a partial equivalent to the resizeMode style and prop of Image.
Changelog
[General] [Added] - Add support for objectFit style of Image.
Test Plan