Skip to content

feat: Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>. - #34576

Closed
gedeagas wants to merge 5 commits into
react:mainfrom
gedeagas:feat/objectFit
Closed

feat: Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>.#34576
gedeagas wants to merge 5 commits into
react:mainfrom
gedeagas:feat/objectFit

Conversation

@gedeagas

@gedeagasgedeagas commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

Summary

This PR aims to add support for objectFit a partial equivalent to the resizeMode style and prop of Image.

Changelog

[General] [Added] - Add support for objectFit style of Image.

Test Plan

  1. Open the RNTester app and navigate to the Image page
  2. See the Object Fit section.

Screenshot_1662112702

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2022
@gedeagas

Copy link
Copy Markdown
ContributorAuthor

Task Umbrella
#34425

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022
@gedeagasgedeagas changed the title feat(objectFit): Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>.feat: Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>.Sep 2, 2022
@react-native-botreact-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 2, 2022
@analysis-bot

analysis-bot commented Sep 2, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,637,129+489
androidhermesarmeabi-v7a7,049,127+494
androidhermesx867,939,086+479
androidhermesx86_647,911,113+473
androidjscarm64-v8a9,513,217+290
androidjscarmeabi-v7a8,288,514+292
androidjscx869,452,752+269
androidjscx86_6410,044,007+289

Base commit: 12e5842
Branch: main

@analysis-bot

analysis-bot commented Sep 2, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 12e5842
Branch: main

Comment threadLibraries/Image/Image.android.js Outdated
Comment threadLibraries/Image/ImageProps.js Outdated
@gedeagas

Copy link
Copy Markdown
ContributorAuthor

Resolved, please re review @necolas

@gedeagas

Copy link
Copy Markdown
ContributorAuthor

Hi @necolas seems that this PR #34585 is already imported to phabricator thus makes this PR obsolete (?). Should i close this?

@necolas

Copy link
Copy Markdown

No, this is the first PR and the one we focused on. Close the other one

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @gedeagas in b2452ab.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Sep 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Needs TypeScript UpdateShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Type: EnhancementA new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@gedeagas@analysis-bot@necolas@facebook-github-bot@react-native-bot@lunaleaps