Uh oh!
There was an error while loading. Please reload this page.
feat: Added pointerEvents style equivalent to pointerEvents prop - #34586
Closed
cyrus25 wants to merge 3 commits into
Closed
feat: Added pointerEvents style equivalent to pointerEvents prop#34586cyrus25 wants to merge 3 commits into
cyrus25 wants to merge 3 commits into
Conversation
Base commit: 12e5842 |
analysis-bot
commented
Sep 3, 2022
Base commit: 12e5842 |
facebook-github-bot
commented
Sep 5, 2022
Contributor
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Sep 5, 2022
Collaborator
This pull request was successfully merged by @cyrus25 in 5c109b3. When will my fix make it into a release? | Upcoming Releases |
necolas
reviewed
Sep 5, 2022
| forwardedRef, | ||
| ) => { | ||
| const flattendStyle = flattenStyle(style); | ||
| const newPointerEvents = pointerEvents || flattendStyle?.pointerEvents; |
There was a problem hiding this comment.
We probably should have made the style take priority
necolas
reviewed
Sep 5, 2022
| {tabIndex, focusable, style, pointerEvents, ...otherProps}: ViewProps, | ||
| forwardedRef, | ||
| ) => { | ||
| const flattendStyle = flattenStyle(style); |
74 tasks
cyrus25
commented
Sep 5, 2022
ContributorAuthor
facebook-github-bot pushed a commit
that referenced
this pull request
Sep 6, 2022
Summary: Make style pointerEvents take priority over pointerEvents prop. Fixes requested changes in #34586 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - Make style pointerEvents take priority over pointerEvents prop. FIxes requested changes in #34586 Pull Request resolved: #34597 Test Plan: Will rely on green cli Reviewed By: NickGerleman Differential Revision: D39269306 Pulled By: cipolleschi fbshipit-source-id: 0927bf6ad7e3ac63e82dbd1a873532152f29001d
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds
pointerEventsstyle which is equivalent topointerEventsprop as requested in #34425Changelog
[General] [Added] - Added pointerEvents style equivalent to pointerEvents prop
Test Plan