Skip to content

Feat/fontweight number value - #34598

Closed
ankit-tailor wants to merge 6 commits into
react:mainfrom
ankit-tailor:feat/fontweight-number-value
Closed

Feat/fontweight number value#34598
ankit-tailor wants to merge 6 commits into
react:mainfrom
ankit-tailor:feat/fontweight-number-value

Conversation

@ankit-tailor

Copy link
Copy Markdown
Contributor

Summary

This PR adds support for number values for fontWeight as requested in #34425.

Changelog

[General] [Added] - Added support for number values in fontWeight.

Test Plan

<Textstyle={{fontWeight: 900,color: 'red'}}>
Hello World
</Text>

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 5, 2022
@react-native-botreact-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 5, 2022
@analysis-bot

analysis-bot commented Sep 5, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 4f6929b
Branch: main

@analysis-bot

analysis-bot commented Sep 5, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,638,097+1,062
androidhermesarmeabi-v7a7,050,075+841
androidhermesx867,940,060+1,222
androidhermesx86_647,912,080+1,309
androidjscarm64-v8a9,513,807+978
androidjscarmeabi-v7a8,289,094+760
androidjscx869,453,350+1,135
androidjscx86_6410,044,592+1,229

Base commit: 4f6929b
Branch: main

Comment threadLibraries/Text/Text.js Outdated
@necolas

Copy link
Copy Markdown

Are there any existing unit tests that we can expand to include this change?

@ankit-tailor

Copy link
Copy Markdown
ContributorAuthor

No, I couldn't find any existing tests.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Comment threadLibraries/Text/Text.js Outdated
Co-authored-by: Fedir Ushakov <pmahotsava@gmail.com>
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @ankit-tailor in f1c1f81.

When will my fix make it into a release? | Upcoming Releases

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Type: EnhancementA new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ankit-tailor@analysis-bot@necolas@facebook-github-bot@react-native-bot@todorone