Skip to content

fix: add mixed to aria-checked typings - #34633

Closed
ankit-tailor wants to merge 3 commits into
react:mainfrom
ankit-tailor:fix/aria-checked-typings-for-alias
Closed

fix: add mixed to aria-checked typings#34633
ankit-tailor wants to merge 3 commits into
react:mainfrom
ankit-tailor:fix/aria-checked-typings-for-alias

Conversation

@ankit-tailor

@ankit-tailorankit-tailor commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Summary

aria-checked prop should accept mixed as value as given here and also accessibilityState.checked accepts mixed to represent checkboxes. This change refers to issue #34424 and PR #34524

Changelog

[General] [Added] - Added mixed value for aria-checked.

Test Plan

<TouchableOpacityaccessibilityRole="checkbox"aria-checked="mixed"accessibilityHint="click me to change state"><Text>Checkbox example</Text></TouchableOpacity>

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 8, 2022
@react-native-botreact-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 8, 2022
@analysis-bot

analysis-bot commented Sep 8, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,747,611+0
androidhermesarmeabi-v7a7,149,395+0
androidhermesx868,058,588+0
androidhermesx86_648,029,524+0
androidjscarm64-v8a9,608,518+0
androidjscarmeabi-v7a8,373,768+0
androidjscx869,555,784+0
androidjscx86_6410,148,324+0

Base commit: 0d3596a
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@rubennorte has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot

analysis-bot commented Sep 9, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 0d3596a
Branch: main

@necolas

Copy link
Copy Markdown

There was an internal request to update the typescript types too. cc @lunaleaps

@lunaleapslunaleaps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankit-tailor

Copy link
Copy Markdown
ContributorAuthor

Yes @lunaleaps, I'll do the necessary changes.

@ankit-tailor

Copy link
Copy Markdown
ContributorAuthor

@lunaleaps, Only ViewAccessibility props required the above changes, other than that everywhere else ViewAccessibility props are extended.

@gabrieldonadel

Copy link
Copy Markdown
Collaborator

@lunaleaps any updates on this?

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @ankit-tailor in 7a19af7.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Oct 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Type: EnhancementA new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ankit-tailor@analysis-bot@facebook-github-bot@necolas@gabrieldonadel@react-native-bot@lunaleaps