chore: renamed react-native-codegen to @react-native/codegen by shivenmian · Pull Request #34804 · react/react-native

shivenmian · 2022-09-27T19:29:37Z

Summary

Renamed react-native-codegen package to @react-native/codegen and updated references, without changing the folder name; part of RFC480 (#34692). Follow-up from #34578

Changelog

[General] [Changed] - Renamed react-native-codegen package to @react-native/codegen and updated references

Test Plan

facebook-github-bot · 2022-09-28T10:40:49Z

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

shivenmian · 2022-09-29T22:26:49Z

@cortinico done. I'm not seeing the test_js task btw - CircleCI isn't running. Is there something more I need to do for that?

cortinico · 2022-10-03T11:40:11Z

I think we can just remove this section entierly

cortinico · 2022-10-03T11:41:25Z

something more I need to do for that?

Let's try to rebase. If it's still not working, I'll try to look more closely into this

shivenmian · 2022-10-04T00:36:22Z

@cortinico done. I'm getting a "workflow awaiting approval" message - perhaps that's why CircleCI did not run?

cortinico · 2022-10-04T10:37:17Z

/rebase

analysis-bot · 2022-10-04T11:05:35Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,103,533	+0
android	hermes	armeabi-v7a	6,471,857	+0
android	hermes	x86	7,521,168	+0
android	hermes	x86_64	7,380,054	+0
android	jsc	arm64-v8a	8,968,359	+0
android	jsc	armeabi-v7a	7,699,467	+0
android	jsc	x86	9,030,658	+0
android	jsc	x86_64	9,508,690	+0

Base commit: ca1ae5c
Branch: main

cortinico · 2022-10-04T11:14:26Z

Hey @shivenmian, I've rebased your PR as the CI was not running.
Now eslint is failing on CI. Are you able to take a look at it?

analysis-bot · 2022-10-04T11:44:18Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: ca1ae5c
Branch: main

shivenmian · 2022-10-05T07:59:25Z

@cortinico fixed and rebased. Should pass now once you approve the workflow / run circleci

cortinico · 2022-10-05T17:39:56Z

/rebase

cortinico · 2022-10-05T17:40:30Z

CircleCI is failing to run on this PR, not sure why. I've attempted an autorebase, let's see if this unblocks the situation

shivenmian · 2022-10-06T21:55:21Z

@cortinico looks like the JS loop passed. It doesn't seem like the Android / Windows loop failures are related to this, and the iOS one seems like it can't find @react-native/codegen from npm - this should be fixed once the package change makes it way up to npm as well?

shivenmian · 2022-10-11T03:24:55Z

@cortinico this good to go?

cortinico · 2022-10-14T19:51:39Z

@cortinico this good to go?

Sorry I was off some days and missed this ping.
The PR seems good to go. I'm investigating if we can use Verdaccio also for the template tests similarly to what we did here #34577

Is this something you would be interested in looking into setting up for the whole React Native repo (as this would unblock a lot of other PRs like this one).

shivenmian · 2022-10-17T23:16:26Z

Sure. Quick question:

I'm investigating if we can use Verdaccio also for the template tests similarly to what we did here #34577

By "template tests", do you mean the tests that are failing right now on this PR (i.e test_android_template_... and test_ios_template_...)?

hoxyq · 2022-11-24T12:16:20Z

Hey @shivenmian, thanks for contributing. To make this work (both internally and in open-source) I need to add some changes. Could you please share if this is okay for you?

pull-bot · 2022-11-25T17:27:01Z

PR build artifact for c6b4f6961daa8dbc9533abaefb06ffb90d763151 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T17:28:47Z

PR build artifact for c6b4f6961daa8dbc9533abaefb06ffb90d763151 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T19:07:19Z

PR build artifact for b9a36dfd394890f51f3a1aebb720c600b1e4ac57 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T19:12:40Z

PR build artifact for b9a36dfd394890f51f3a1aebb720c600b1e4ac57 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

shivenmian · 2022-11-25T19:18:01Z

@hoxyq yep go ahead!

pull-bot · 2022-11-25T21:49:12Z

PR build artifact for d2840780bdd7c781dd1599d39869d7a666fd990a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T21:55:19Z

PR build artifact for d2840780bdd7c781dd1599d39869d7a666fd990a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

…t_phases.sh

pull-bot · 2022-11-26T10:26:54Z

PR build artifact for 720b05d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-26T10:34:25Z

PR build artifact for 720b05d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

…ct-native-modules

facebook-github-bot · 2022-11-26T11:00:27Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pull-bot · 2022-11-26T11:19:55Z

PR build artifact for 512523e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-26T11:22:01Z

PR build artifact for 512523e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

react-native-bot · 2022-11-28T16:50:09Z

This pull request was successfully merged by @shivenmian in b7a85b5.

^{When will my fix make it into a release? | Upcoming Releases}

shivenmian requested a review from hramos as a code owner September 27, 2022 19:29

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Sep 27, 2022

shivenmian mentioned this pull request Sep 27, 2022
chore: refactor react-native-codegen into packages/codegen #34578
Closed

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 27, 2022

kelset added the Tech: Monorepo For PRs that are related to the monorepo infra label Sep 28, 2022

cortinico reviewed Sep 28, 2022
View reviewed changes

Comment threadCHANGELOG.md Outdated

cortinico reviewed Oct 3, 2022
View reviewed changes

Comment thread.circleci/verdaccio.yml Outdated
Comment on lines 29 to 31
cortinicoOct 3, 2022
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just remove this section entierly

shivenmian force-pushed the rn_refactor_codegen branch from 6fc49c0 to dc38a26Compare October 4, 2022 00:34

github-actionsBotforce-pushed the rn_refactor_codegen branch from dc38a26 to 600d173Compare October 4, 2022 10:39

cortinico mentioned this pull request Oct 4, 2022
☂️ React Native Monorepo #34692
Closed
11 tasks

shivenmian force-pushed the rn_refactor_codegen branch 2 times, most recently from 11dc296 to 8c475f7Compare October 5, 2022 07:57

github-actionsBotforce-pushed the rn_refactor_codegen branch from 8c475f7 to 73bd2e6Compare October 5, 2022 17:42

hoxyq force-pushed the rn_refactor_codegen branch from 73bd2e6 to c6b4f69Compare November 25, 2022 16:18

hoxyq force-pushed the rn_refactor_codegen branch from c6b4f69 to b9a36dfCompare November 25, 2022 18:33

hoxyq force-pushed the rn_refactor_codegen branch from b9a36df to d284078Compare November 25, 2022 21:20

shivenmianand others added 4 commits November 26, 2022 09:56

chore: renamed react-native-codegen to @react-native/codegen
41fcb07

fix: restored CHANGELOG
01ce8e4

fix: updated codegen src paths
820104f

fix: update codegen location in scripts/react_native_pods_utils/scrip…
720b05d
…t_phases.sh

hoxyq force-pushed the rn_refactor_codegen branch from d284078 to 720b05dCompare November 26, 2022 09:58

hoxyq force-pushed the rn_refactor_codegen branch from cd284fe to bd2a4aeCompare November 26, 2022 10:49

fix: update eslint-plugin-specs paths for react-native/codegen in rea…
512523e
…ct-native-modules

hoxyq force-pushed the rn_refactor_codegen branch from bd2a4ae to 512523eCompare November 26, 2022 10:49

facebook-github-bot closed this in b7a85b5Nov 28, 2022

react-native-bot added the Merged This PR has been merged. label Nov 28, 2022

hoxyq mentioned this pull request Jan 2, 2023
[General] [Fixed] - Fixes react-native-codegen location within script_phases.sh #35763
Closed

Uh oh!

Conversation

shivenmian commented Sep 27, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

facebook-github-bot commented Sep 28, 2022

Uh oh!

Uh oh!

shivenmian commented Sep 29, 2022

Uh oh!

cortinicoOct 3, 2022

Choose a reason for hiding this comment

Uh oh!

cortinico commented Oct 3, 2022

Uh oh!

shivenmian commented Oct 4, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cortinico commented Oct 4, 2022

Uh oh!

analysis-bot commented Oct 4, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cortinico commented Oct 4, 2022

Uh oh!

analysis-bot commented Oct 4, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivenmian commented Oct 5, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cortinico commented Oct 5, 2022

Uh oh!

cortinico commented Oct 5, 2022

Uh oh!

shivenmian commented Oct 6, 2022

Uh oh!

shivenmian commented Oct 11, 2022

Uh oh!

cortinico commented Oct 14, 2022

Uh oh!

shivenmian commented Oct 17, 2022

Uh oh!

hoxyq commented Nov 24, 2022

Uh oh!

pull-bot commented Nov 25, 2022

Uh oh!

pull-bot commented Nov 25, 2022

Uh oh!

pull-bot commented Nov 25, 2022

Uh oh!

pull-bot commented Nov 25, 2022

Uh oh!

shivenmian commented Nov 25, 2022

Uh oh!

pull-bot commented Nov 25, 2022

Uh oh!

pull-bot commented Nov 25, 2022

Uh oh!

pull-bot commented Nov 26, 2022

Uh oh!

pull-bot commented Nov 26, 2022

Uh oh!

facebook-github-bot commented Nov 26, 2022

Uh oh!

pull-bot commented Nov 26, 2022

Uh oh!

pull-bot commented Nov 26, 2022

Uh oh!

react-native-bot commented Nov 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

shivenmian commented Sep 27, 2022•
edited
Loading

shivenmian commented Oct 4, 2022•
edited
Loading

analysis-bot commented Oct 4, 2022•
edited
Loading

analysis-bot commented Oct 4, 2022•
edited
Loading

shivenmian commented Oct 5, 2022•
edited
Loading