Skip to content

file to Renamed react-native-gradle-plugin to @react-native/gradle-pl… - #34835

Closed
code3002 wants to merge 0 commit into
react:mainfrom
code3002:main
Closed

file to Renamed react-native-gradle-plugin to @react-native/gradle-pl…#34835
code3002 wants to merge 0 commit into
react:mainfrom
code3002:main

Conversation

@code3002

@code3002code3002 commented Oct 1, 2022

Copy link
Copy Markdown

…ugin

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@code3002
code3002 requested a review from hramos as a code ownerOctober 1, 2022 12:08
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2022
@github-actions

github-actionsBot commented Oct 1, 2022

Copy link
Copy Markdown
Fails
🚫

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 6a04922e4e6f2fd2e749ef1d7ab5b43858f973f9

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 1, 2022
cortinico
cortinico requested changes Oct 3, 2022
View reviewed changes

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sendign this @rahul3002
I noticed you used the wrong string react-native/gradle-plugin.
It should be instead @react-native/gradle-plugin

Please update all the occurencies

Comment thread.circleci/verdaccio.yml Outdated
Comment on lines 32 to 34

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this block entirely

Comment thread.gitignore Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/packages/react-native/gradle-plugin./build/
/packages/react-native/gradle-plugin/build/

Comment threadCHANGELOG.md Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not edit the CHANGELOG

Comment threadbuild.gradle.kts Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not edit this line as the path is not changing

Comment threadbuild.gradle.kts Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not edit this line as the path is not changing

Comment threadbuild.gradle.kts Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not edit this line as the path is not changing

Comment threadpackage.json Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"react-native/gradle-plugin.": "^0.71.4",
"react-native/gradle-plugin": "^0.71.4",

Comment threadpackages/react-native-gradle-plugin/README.md Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# react-native/gradle-plugin.
# @react-native/gradle-plugin

Comment threadpackages/react-native-gradle-plugin/README.md Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
yarn add react-native/gradle-plugin.
yarn add @react-native/gradle-plugin

Comment threadpackages/react-native-gradle-plugin/package.json Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "react-native/gradle-plugin.",
"name": "@react-native/gradle-plugin",

This needs to be fixed all over your PR

@cortinicocortinico mentioned this pull request Oct 4, 2022
Closed
11 tasks
@cortinicocortinico added the Tech: Monorepo For PRs that are related to the monorepo infra label Oct 4, 2022
@hoxyq

hoxyq commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Hey @rahul3002,

Thanks for working on this. I am now planning to continue your work and need to introduce some changes, before we can merge this. Can you share if you had any plans onto working on this later or can I just take it?

@hoxyqhoxyq closed this Nov 24, 2022
@hoxyq

hoxyq commented Nov 24, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Oops, looks like it automatically closed after my push and right now I am unable to push to rahul3002/main
I've pushed just main branch by mistake, so there is no commits, thats why it probably closed

I am also unable to reopen PR now :(

@analysis-bot

analysis-bot commented Nov 24, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,103,561+0
androidhermesarmeabi-v7a6,471,886+0
androidhermesx867,521,203+0
androidhermesx86_647,380,081+0
androidjscarm64-v8a8,968,399+0
androidjscarmeabi-v7a7,699,505+0
androidjscx869,030,706+0
androidjscx86_649,508,749+0

Base commit: 6a45f2c
Branch: main

@analysis-bot

analysis-bot commented Nov 24, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 6a45f2c
Branch: main

@pull-bot

pull-bot commented Nov 24, 2022

Copy link
Copy Markdown

PR build artifact for 4c5eb8d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

pull-bot commented Nov 24, 2022

Copy link
Copy Markdown

PR build artifact for 4c5eb8d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinicocortinicocortinico requested changes
@hramoshramosAwaiting requested review from hramos

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Tech: MonorepoFor PRs that are related to the monorepo infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@code3002@hoxyq@analysis-bot@pull-bot@cortinico@facebook-github-bot