Skip to content

Fix issues for nightly build - #34846

Closed
Kudo wants to merge 2 commits into
react:mainfrom
Kudo:fix-nightly
Closed

Fix issues for nightly build#34846
Kudo wants to merge 2 commits into
react:mainfrom
Kudo:fix-nightly

Conversation

@Kudo

@KudoKudo commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Summary

There are two issues from nightly builds.

1. VERSION_NAME=1000.0.0-main in ReactAndroid/gradle.properties

the solution is to remove unused ReactAndroid/gradle.properties git revert when publishing package.

2. pod install error from downloading hermes, e.g. the url is unavailable. https://github.com/facebook/react-native/releases/download/v0.0.0-20221002-2027-2319f75c8/hermes-runtime-darwin-debug-v0.0.0-20221002-2027-2319f75c8.tar.gz

fix hermes-engine.podspec to support nightly build and build hermes from main branch.

Changelog

[General] [Fixed] - Fix nightly build issues

Test Plan

  1. i cannot fully test publish-npm.js workflow and it stops at npm publish. i can just check at this moment, the ReactAndroid/gradle.properties is right.
  2. create a npx react-native init project and yarn add react-native@nightly. patch node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec and try pod install

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 3, 2022
@KudoKudo mentioned this pull request Oct 3, 2022
Closed
@analysis-bot

analysis-bot commented Oct 3, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,739,161+0
androidhermesarmeabi-v7a7,141,579+0
androidhermesx868,050,059+0
androidhermesx86_648,021,773+0
androidjscarm64-v8a9,607,326+0
androidjscarmeabi-v7a8,372,583+0
androidjscx869,554,794+0
androidjscx86_6410,147,276+0

Base commit: 9d08d55
Branch: main

cortinico
cortinico approved these changes Oct 3, 2022
View reviewed changes
Comment threadsdks/hermes-engine/hermes-engine.podspec Outdated

@cortinicocortinicoOct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to change soon as we're looking for a place where to store hermes tarballs also for nightlies: react-native-community/discussions-and-proposals#508

@KudoKudoOct 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's super helpful where we could test nightly without building hermes from source 🎉

@cortinico

cortinico commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

cc @kelset as you've been working on this recently

@facebook-github-bot

facebook-github-bot commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kelset

kelset commented Oct 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

hey @Kudo - for context, I've done changes in this area of the code in two places:

lmk if there's anything I need to modify over there to ensure everything works correctly

@Kudo

Kudo commented Oct 3, 2022

Copy link
Copy Markdown
ContributorAuthor

hey @Kudo - for context, I've done changes in this area of the code in two places:

lmk if there's anything I need to modify over there to ensure everything works correctly

thanks for these information @kelset. the pr is not in hurry at all, as at expo we have some postinstall workaround to fix these issues. i can wait your prs to be landed first and see if there're any necessary changes then.

@KudoKudo mentioned this pull request Oct 3, 2022
Merged
3 tasks
@Kudo

Kudo commented Oct 3, 2022

Copy link
Copy Markdown
ContributorAuthor

oh no this pr landed first, sorry @kelset 😅 let me know if there's anything i can help for your prs .

@kelset

kelset commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

ahah no worries, I'll probably have a new small merge conflict to handle but everything should be fine 👍

@react-native-bot

react-native-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Kudo in 93c3eff.

When will my fix make it into a release? | Upcoming Releases

1 similar comment
@react-native-bot

react-native-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Kudo in 93c3eff.

When will my fix make it into a release? | Upcoming Releases

@Kudo

Kudo commented Oct 3, 2022

Copy link
Copy Markdown
ContributorAuthor

thanks @kelset and everyone helps with pr reviews as always.

@Kudo
Kudo deleted the fix-nightly branch October 3, 2022 15:31
@react-native-bot

react-native-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Kudo in 93c3eff.

When will my fix make it into a release? | Upcoming Releases

5 similar comments
@react-native-bot

react-native-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Kudo in 93c3eff.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot

react-native-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Kudo in 93c3eff.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot

react-native-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Kudo in 93c3eff.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot

react-native-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Kudo in 93c3eff.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot

react-native-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Kudo in 93c3eff.

When will my fix make it into a release? | Upcoming Releases

@reactreact locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.p: ExpoPartner: ExpoPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kudo@analysis-bot@cortinico@facebook-github-bot@kelset@react-native-bot