Skip to content

refactor(react-native-github): move ImagePickerIOS to internal - #35199

Closed
hoxyq wants to merge 1 commit into
react:mainfrom
hoxyq:export-D40859520
Closed

refactor(react-native-github): move ImagePickerIOS to internal#35199
hoxyq wants to merge 1 commit into
react:mainfrom
hoxyq:export-D40859520

Conversation

@hoxyq

@hoxyqhoxyq commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

Summary:
Changelog:
[iOS][Removed] - Removed ImagePickerIOS module native sources
[JS][Removed] - Removed ImagePickerIOS module from react-native

Reviewed By: cortinico

Differential Revision: D40859520

Summary:
**Changelog:**
[iOS][Removed] - Removed ImagePickerIOS module native sources
[JS][Removed] - Removed ImagePickerIOS module from react-native
Reviewed By: cortinico
Differential Revision: D40859520
fbshipit-source-id: ca95d041469b99e6b3fcf846347c813ab090e338
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 4, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D40859520

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a6,991,606-670
androidhermesarmeabi-v7a6,368,151-667
androidhermesx867,404,296-674
androidhermesx86_647,268,306-673
androidjscarm64-v8a8,855,723-424
androidjscarmeabi-v7a7,594,245-408
androidjscx868,913,475-422
androidjscx86_649,396,826-419

Base commit: 35ebb57
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 35ebb57
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for 9faa84a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for 9faa84a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @hoxyq in d03a29c.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Nov 4, 2022
kelset pushed a commit that referenced this pull request Nov 22, 2022
Summary:
Pull Request resolved: #35199
**Changelog:**
[iOS][Removed] - Removed ImagePickerIOS module native sources
[JS][Removed] - Removed ImagePickerIOS module from react-native
Reviewed By: cortinico
Differential Revision: D40859520
fbshipit-source-id: a6a114a05574d46ea62600999bff95025ba7cdc8
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartnerPlatform: iOSiOS applications.Type: Removal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@hoxyq@facebook-github-bot@analysis-bot@pull-bot@react-native-bot