Skip to content

react-native-codegen: Enable C++ TurboModule generation in OpenSource builds - #35211

Closed
christophpurrer wants to merge 1 commit into
react:mainfrom
christophpurrer:export-D41057630
Closed

react-native-codegen: Enable C++ TurboModule generation in OpenSource builds#35211
christophpurrer wants to merge 1 commit into
react:mainfrom
christophpurrer:export-D41057630

Conversation

@christophpurrer

Copy link
Copy Markdown
Contributor

Summary:
This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in #35138

Changelog: [Internal]

Differential Revision: D41057630

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 5, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057630

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,034,677+39,333
androidhermesarmeabi-v7a6,412,135+40,253
androidhermesx867,452,257+44,226
androidhermesx86_647,313,126+41,086
androidjscarm64-v8a8,900,494+39,335
androidjscarmeabi-v7a7,639,916+40,245
androidjscx868,963,129+44,225
androidjscx86_649,443,332+41,064

Base commit: f0b7cbe
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057630

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: f0b7cbe
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for 782489060714f3cb22e8fa41b4326683f0cb99a3 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057630

@pull-bot

Copy link
Copy Markdown

PR build artifact for d8cfce264f6fffb68f840610b0f1543822ef007d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

… builds (react#35211)
Summary:
Pull Request resolved: react#35211
This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.
An example is shown in react#35138
Changelog: [Internal]
Differential Revision: D41057630
fbshipit-source-id: 74d2d1f24bd0dd156cf5268d08af458393e574e3
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057630

@pull-bot

Copy link
Copy Markdown

PR build artifact for 0229239 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @christophpurrer in 35b2150.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Nov 7, 2022
kelset pushed a commit that referenced this pull request Nov 22, 2022
… builds (#35211)
Summary:
Pull Request resolved: #35211
This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.
An example is shown in #35138
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D41057630
fbshipit-source-id: 303881a63eb82f0fe8dfe10e533043a6eedb3d11
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@christophpurrer@facebook-github-bot@analysis-bot@pull-bot@react-native-bot