Uh oh!
There was an error while loading. Please reload this page.
feat: Update TextInput inputMode to map "none" to showSoftInputOnFocus - #35228
feat: Update TextInput inputMode to map "none" to showSoftInputOnFocus#35228gabrieldonadel wants to merge 2 commits into
Conversation
necolas
commented
Nov 7, 2022
I wonder if this should be a little more complicated in case it's bizarre to have an inputMode set and the showSoftInputOnFocus set. Should the latter be ignored entirely if inputMode is defined? |
Base commit: 7a327d9 |
Base commit: 7a327d9 |
pull-bot
commented
Nov 7, 2022
PR build artifact for 0b660f4 is ready. |
gabrieldonadel
commented
Nov 7, 2022
@necolas we could do |
facebook-github-bot
commented
Nov 7, 2022
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
necolas
commented
Nov 7, 2022
I was thinking more like |
gabrieldonadel
commented
Nov 7, 2022
Got it, I've just updated it to use this logic |
necolas
commented
Nov 7, 2022
Thanks. We'll reimport and double check |
facebook-github-bot
commented
Nov 7, 2022
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pull-bot
commented
Nov 7, 2022
PR build artifact for dc20e4e is ready. |
react-native-bot
commented
Nov 8, 2022
This pull request was successfully merged by @gabrieldonadel in b6869be. When will my fix make it into a release? | Upcoming Releases |
Summary
This PR updates
inputModeprop from theTextInputcomponent to map thenoneoption toshowSoftInputOnFocus={false}as suggested by @necolas here -> #34460 (comment). This change makes the inputMode API behaves a bit more similarly across platforms.Related to necolas/react-native-web#2421
Changelog
[General] [Changed] - Update TextInput inputMode to map "none" to showSoftInputOnFocus
Test Plan
TextInputcomponent through theInput modessectionScreen.Recording.2022-11-07.at.00.08.58.mov