Uh oh!
There was an error while loading. Please reload this page.
Fix avoid forcing podspec versions - #35274
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
commented
Nov 9, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: c0f06e8 |
cipolleschiforce-pushed
the
cipolleschi/fix_avoid_forcing_podspec_versions
branch
from
November 14, 2022 15:27
1062e0f to
91b6d36Comparefacebook-github-bot
commented
Nov 14, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
analysis-bot
commented
Nov 14, 2022
Base commit: c0f06e8 |
kelset pushed a commit
that referenced
this pull request
Nov 22, 2022
Summary: This is a backport of [this](becb47c) local fix we made on 0.71-stable. All our podspecs delegates to the main React Native pods script to set up the dependencies properly. The React-Codegen.podspec, which is generated by the script itself, was generated with hardcoded dependencies. This PR aligns the versioning with the other podspec. On a side note, this could create issues in CI and when releaseing, because we are changing the versions to prepare the new release and it breaks some steps. ## Changelog [iOS] [Fixed] - Make sure that the React-Codegen.podspec does not enforce specific versions of its dependencies. Pull Request resolved: #35274 Test Plan: 1. Ruby tests are passing 2. Manually tested that pods are correctly installed in the following configurations - RNTester - Hermes - Old Architecture - RNTester - Hermes - New Architecture - RNTester - JSC - Old Architecture - RNTester - JSC - New Architecture Reviewed By: christophpurrer Differential Revision: D41153859 Pulled By: cipolleschi fbshipit-source-id: 043513866a66ecca3e326f8671bea3ec576422de # Conflicts: # scripts/cocoapods/codegen_utils.rb
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a backport of this local fix we made on
0.71-stable.
All our podspecs delegates to the main React Native pods script to set up the dependencies properly. The React-Codegen.podspec, which is generated by
the script itself, was generated with hardcoded dependencies. This PR aligns the versioning with the other podspec.
On a side note, this could create issues in CI and when releaseing, because we are changing the versions to prepare the new release and it breaks some
steps.
Changelog
[iOS] [Fixed] - Make sure that the React-Codegen.podspec does not enforce specific versions of its dependencies.
Test Plan