Remove version from the tarball by cipolleschi · Pull Request #35285 · react/react-native

cipolleschi · 2022-11-09T13:11:11Z

Summary:
While doing the release 0f 0.71.0-RC0, we noticed that having the RN version in the hermes tarball was causing more harm than good.

With the version in the name, we ended up with multiple tarballs for debug and release and we were not able to explicitly pick the right tarball given a build.

This change remove the version from the tarball name.

Changelog

[General][Changed] - Remove React Native version from Hermes tarball name

Differential Revision: D41156353

facebook-github-bot · 2022-11-09T13:11:41Z

This pull request was exported from Phabricator. Differential Revision: D41156353

analysis-bot · 2022-11-09T13:32:25Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 5744b21
Branch: main

analysis-bot · 2022-11-09T13:34:42Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,070,038	+0
android	hermes	armeabi-v7a	6,442,174	+0
android	hermes	x86	7,485,033	+0
android	hermes	x86_64	7,344,612	+0
android	jsc	arm64-v8a	8,934,550	+0
android	jsc	armeabi-v7a	7,668,661	+0
android	jsc	x86	8,994,599	+0
android	jsc	x86_64	9,473,532	+0

Base commit: 5744b21
Branch: main

pull-bot · 2022-11-09T13:45:26Z

PR build artifact for f196b1340490ad699443c3c02be51ffb94e725d4 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-09T13:48:45Z

PR build artifact for f196b1340490ad699443c3c02be51ffb94e725d4 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-09T13:51:01Z

This pull request was exported from Phabricator. Differential Revision: D41156353

facebook-github-bot · 2022-11-09T14:10:13Z

This pull request was exported from Phabricator. Differential Revision: D41156353

pull-bot · 2022-11-09T14:42:23Z

PR build artifact for 5479d54de70e88de76a4d3907673a74bea6848ca is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-09T14:45:51Z

PR build artifact for 5479d54de70e88de76a4d3907673a74bea6848ca is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary: Pull Request resolved: #35285 While doing the release 0f 0.71.0-RC0, we noticed that having the RN version in the hermes tarball was causing more harm than good. With the version in the name, we ended up with multiple tarballs for debug and release and we were not able to explicitly pick the right tarball given a build. This change remove the version from the tarball name. ## Changelog [General][Changed] - Remove React Native version from Hermes tarball name Differential Revision: D41156353 fbshipit-source-id: cf47c67e94e1b0c6319d82babd8780e9c82566cd

facebook-github-bot · 2022-11-09T15:10:43Z

This pull request was exported from Phabricator. Differential Revision: D41156353

pull-bot · 2022-11-09T15:44:18Z

PR build artifact for 8ecc2ec is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-09T15:50:31Z

PR build artifact for 8ecc2ec is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

cipolleschi · 2022-11-14T15:41:45Z

/rebase

Summary: Pull Request resolved: #35285 While doing the release 0f 0.71.0-RC0, we noticed that having the RN version in the hermes tarball was causing more harm than good. With the version in the name, we ended up with multiple tarballs for debug and release and we were not able to explicitly pick the right tarball given a build. This change remove the version from the tarball name. ## Changelog [General][Changed] - Remove React Native version from Hermes tarball name Reviewed By: lunaleaps Differential Revision: D41156353 fbshipit-source-id: 8899d5e1e1555bc728d923f3b78d1261e6ff09c7

cipolleschi requested a review from hramos as a code owner November 9, 2022 13:11

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 9, 2022

cipolleschi force-pushed the export-D41156353 branch from f196b13 to 25f996bCompare November 9, 2022 13:51

cipolleschi force-pushed the export-D41156353 branch from 25f996b to 5479d54Compare November 9, 2022 14:10

cipolleschi force-pushed the export-D41156353 branch from 5479d54 to 8ecc2ecCompare November 9, 2022 15:11

facebook-github-bot closed this in e36c492Nov 14, 2022

cipolleschi mentioned this pull request Nov 22, 2022
[LOCAL] Bypass tag check in dry run #35428
Merged

cipolleschi mentioned this pull request Aug 16, 2023
cipolleschi/add maven polling #39039
Merged

cipolleschi mentioned this pull request Sep 21, 2023
[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39577
Merged

cipolleschi mentioned this pull request Oct 11, 2023
cipolleschi/fix CI #40793
Merged

cipolleschi mentioned this pull request Nov 1, 2023
[RN][CI]Update node installation on debian (0.71) #41277
Merged

This was referenced Jan 8, 2024
[0.71][RN][General] Migrate boost download url away from JFrog #42177
Merged
[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42229
Merged

cipolleschi mentioned this pull request Mar 6, 2024
[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345
Merged

cipolleschi mentioned this pull request Apr 5, 2024
cipolleschi/fix yoga archive 0.71 #43895
Closed

cipolleschi mentioned this pull request Apr 26, 2024
[iOS][Privacy Manifest] Set up privacy manifest for React Native 0.71 #44281
Merged

Navigation Menu

Uh oh!

Remove version from the tarball - #35285

Remove version from the tarball#35285
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D41156353

cipolleschi commented Nov 9, 2022

Uh oh!

facebook-github-bot commented Nov 9, 2022

Uh oh!

analysis-bot commented Nov 9, 2022

Uh oh!

analysis-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

facebook-github-bot commented Nov 9, 2022

Uh oh!

facebook-github-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

facebook-github-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

cipolleschi commented Nov 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

cipolleschi commented Nov 9, 2022

Changelog

Uh oh!

facebook-github-bot commented Nov 9, 2022

Uh oh!

analysis-bot commented Nov 9, 2022

Uh oh!

analysis-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

facebook-github-bot commented Nov 9, 2022

Uh oh!

facebook-github-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

facebook-github-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

pull-bot commented Nov 9, 2022

Uh oh!

cipolleschi commented Nov 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants