Skip to content

fix: RNTester TransformExample crash - #35292

Closed
gabrieldonadel wants to merge 1 commit into
react:mainfrom
gabrieldonadel:fix/rn-tester-transform-example
Closed

fix: RNTester TransformExample crash#35292
gabrieldonadel wants to merge 1 commit into
react:mainfrom
gabrieldonadel:fix/rn-tester-transform-example

Conversation

@gabrieldonadel

Copy link
Copy Markdown
Collaborator

Summary

As pointed out by @kelset on #34660 (comment) accessing the TransformExample is currently crashing the RNTester app due to missing units in one of the transformers. This PR fixes it by updating the transform value to a valid string.

Changelog

[Internal] [Fixed] - Add missing translate units to RNTesterTransformExample

Test Plan

  1. Open the RNTester app and navigate to the Transforms page
  2. Check the transform style through the Transform using a string section
Screen.Recording.2022-11-09.at.15.53.00.mov

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2022
@necolas

Copy link
Copy Markdown

We should also make the failures yellowboxes not invariants

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: d07575b
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,070,049-31,730
androidhermesarmeabi-v7a6,442,181-29,401
androidhermesx867,485,038-34,271
androidhermesx86_647,344,632-33,223
androidjscarm64-v8a8,934,559-31,314
androidjscarmeabi-v7a7,668,665-28,982
androidjscx868,994,609-33,850
androidjscx86_649,473,539-32,818

Base commit: d07575b
Branch: main

@gabrieldonadel

Copy link
Copy Markdown
CollaboratorAuthor

We should also make the failures yellowboxes not invariants

@necolas should we use yellowboxes even though we only show this error when running on DEV mode? We also do this inside the _validateTransforms function, should we update that as well?

https://github.com/facebook/react-native/blob/bbb3a6146cc24d391843bcaf0a451a2876c14056/Libraries/StyleSheet/processTransform.js#L153-L157

@pull-bot

Copy link
Copy Markdown

PR build artifact for bcba275 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@necolas

Copy link
Copy Markdown

even though we only show this error when running on DEV mode

ah I forgot about that. hmm in which case let's just focus on merging this immediate fix. thanks for the context!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gabrieldonadel
gabrieldonadel deleted the fix/rn-tester-transform-example branch November 9, 2022 21:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gabrieldonadel@necolas@analysis-bot@pull-bot@facebook-github-bot