Uh oh!
There was an error while loading. Please reload this page.
chore: fail prepare package for release if tag exists - #35305
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
cipolleschiforce-pushed
the
cipolleschi/make_prepare_pkg_for_release_fail_if_tag_exists
branch
2 times, most recently
from
November 10, 2022 12:31
6c40af0 to
cc05168Compare
Base commit: 138af74 |
Base commit: 138af74 |
kelset
reviewed
Nov 17, 2022
| echo('You may want to rollback the last commit'); | ||
| echo('git reset --hard HEAD~1'); | ||
| exit(1); | ||
| } |
Contributor
There was a problem hiding this comment.
can you also add this type of logic to bump-oss-script? After L46 would be perfect
ContributorAuthor
There was a problem hiding this comment.
I'm not sure if at line 46 I can access argv. For what I can read, i should manually access yargs... I added it at line 78, right after the extraction of the version.
I also refactored it a little bit to avoid code duplication.
cipolleschiforce-pushed
the
cipolleschi/make_prepare_pkg_for_release_fail_if_tag_exists
branch
from
November 18, 2022 16:26
cc05168 to
fcda861Comparefacebook-github-bot
commented
Nov 18, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschiforce-pushed
the
cipolleschi/make_prepare_pkg_for_release_fail_if_tag_exists
branch
from
November 18, 2022 16:29
fcda861 to
ee46421Comparefacebook-github-bot
commented
Nov 18, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschiforce-pushed
the
cipolleschi/make_prepare_pkg_for_release_fail_if_tag_exists
branch
from
November 21, 2022 11:29
ee46421 to
1f25565Comparefacebook-github-bot
commented
Nov 21, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschiforce-pushed
the
cipolleschi/make_prepare_pkg_for_release_fail_if_tag_exists
branch
from
November 21, 2022 14:01
1f25565 to
8822d6bComparefacebook-github-bot
commented
Nov 21, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kelset
deleted the
cipolleschi/make_prepare_pkg_for_release_fail_if_tag_exists
branch
November 22, 2022 10:23
kelset pushed a commit
that referenced
this pull request
Nov 22, 2022
Summary: This PR makes sure that the `preapre_package_for_release` script fail fast if there is already a tag for the desired version on github. ## Changelog [General] [Added] - Make the `prepare_package_for_release` fail if there is already a git tag with that version Pull Request resolved: #35305 Test Plan: Tested manually. The script is currently only invoked during the release process. <img width="1238" alt="Screenshot 2022-11-10 at 12 24 03" src="https://user-images.githubusercontent.com/11162307/201090947-274c1b1c-0b6a-4619-bc85-fa60e5eaeee1.png"> Reviewed By: cortinico Differential Revision: D41403159 Pulled By: cipolleschi fbshipit-source-id: fb87df345b14568c750482e5c68be53551a9acbb # Conflicts: # scripts/release-utils.js
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes sure that the
preapre_package_for_releasescript fail fast if there is already a tag for the desired versionon github.
Changelog
[General] [Added] - Make the
prepare_package_for_releasefail if there is already a git tag with that versionTest Plan
Tested manually. The script is currently only invoked during the release process.
