Uh oh!
There was an error while loading. Please reload this page.
Fixup template devDependencies - #35372
Closed
NickGerleman wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
commented
Nov 17, 2022
Contributor
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
facebook-github-bot
commented
Nov 17, 2022
Contributor
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Fixes run locally using a new app. The previoius set did not pull in prettier, causing linting to fail. We also saw peerDependency warnings on yarn install. We also saw lint warnings at runtime specific to an unsupported TS version, so we constrain in that version a bit. Changelog: [General][Fixed] - Fixup template devDependencies
NickGerlemanforce-pushed
the
fixup-deps
branch
from
November 17, 2022 01:37
d1bf9c7 to
3d1a55cComparefacebook-github-bot
commented
Nov 17, 2022
Contributor
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
analysis-bot
commented
Nov 17, 2022
Base commit: 1ec1785 |
analysis-bot
commented
Nov 17, 2022
Base commit: 1ec1785 |
pull-bot
commented
Nov 17, 2022
PR build artifact for 3d1a55c is ready. |
pull-bot
commented
Nov 17, 2022
PR build artifact for 3d1a55c is ready. |
kelset pushed a commit
that referenced
this pull request
Nov 22, 2022
Summary: Fixes missing/incorrect devDependencies in a newly built app. The previous set did not pull in prettier, causing linting to fail. There was a peerDependency warning on yarn install. We also saw a separate lint warning at runtime specific to TS 4.9 being pulled in now, so we constrain in that version a bit. Prettier and preset-env versions match the constraints and lockfiles of other RN packages. ## Changelog [General] [Fixed] - Fixup template devDependencies Pull Request resolved: #35372 Test Plan: Created a new app targeting 0.71 via `react-native init`. 1. `yarn install --force` no longer shows warnings 2. `prettier` is installed, `yarn lint` no longer fails, and shows no warnings or errors 3. ~Tentatively a test step to add tests against linting in new app, but last time doing that in CircleCI led to timeouts with no output that I didn't have time to debug, so maybe that's fixed now? �♀️.~ (edit: still hangs) Reviewed By: NickGerleman Differential Revision: D41363021 Pulled By: lunaleaps fbshipit-source-id: d6163b01e8934d75a231fa0fd849d7bde7b3500c
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing/incorrect devDependencies in a newly built app. The previous set did not pull in prettier, causing linting to fail. There was a peerDependency warning on yarn install. We also saw a separate lint warning at runtime specific to TS 4.9 being pulled in now, so we constrain in that version a bit.
Prettier and preset-env versions match the constraints and lockfiles of other RN packages.
Changelog
[General] [Fixed] - Fixup template devDependencies
Test Plan
Created a new app targeting 0.71 via
react-native init.yarn install --forceno longer shows warningsprettieris installed,yarn lintno longer fails, and shows no warnings or errorsTentatively a test step to add tests against linting in new app, but last time doing that in CircleCI led to timeouts with no output that I didn't have time to debug, so maybe that's fixed now? 🤷♀️.(edit: still hangs)