Uh oh!
There was an error while loading. Please reload this page.
Fix: Avoid path in the template import - #35394
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Base commit: 27e7295 |
Base commit: 81e441a |
mikehardy
commented
Nov 18, 2022
Contributor
You somehow managed to break the entire android build with this (I'm joking, of course it didn't, but that is ironic is it not?) |
facebook-github-bot
commented
Nov 18, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
commented
Nov 18, 2022
ContributorAuthor
/rebase |
github-actionsBotforce-pushed
the
cipolleschi/fix_template_appdelegate
branch
from
November 18, 2022 15:26
b7c47e5 to
9e86c90Comparefacebook-github-bot
commented
Nov 18, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
commented
Nov 21, 2022
ContributorAuthor
/rebase |
github-actionsBotforce-pushed
the
cipolleschi/fix_template_appdelegate
branch
from
November 21, 2022 11:12
9e86c90 to
9f06679Comparefacebook-github-bot
commented
Nov 21, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kelset pushed a commit
that referenced
this pull request
Nov 22, 2022
Summary: Investigating [this comment](reactwg/react-native-releases#41 (comment)), I made some tests. It seems like we can simply use `#import <RCTAppDelegate.h>` instead of the `#import <React-RCTAppDelegate/RCTAppDelegate.h>` in both setups: - default setup - `use_frameworks! :linkage => :static` ## Changelog [iOS] [Fixed] - Support `use_framework! :linkage => :static` in template Pull Request resolved: #35394 Test Plan: 1. Manually tested with a new app 2. CircleCI 3. Sandcastle Reviewed By: cortinico Differential Revision: D41402060 Pulled By: cipolleschi fbshipit-source-id: e1ed8196ed860b3663a88f5283f2745e39b0e944
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigating this comment, I made some tests.
It seems like we can simply use
#import <RCTAppDelegate.h>instead of the#import <React-RCTAppDelegate/RCTAppDelegate.h>in both setups:use_frameworks! :linkage => :staticChangelog
[iOS] [Fixed] - Support
use_framework! :linkage => :staticin templateTest Plan