Skip to content

Fix virtual list type - #35434

Closed
aliakbarazizi wants to merge 2 commits into
react:mainfrom
aliakbarazizi:main
Closed

Fix virtual list type#35434
aliakbarazizi wants to merge 2 commits into
react:mainfrom
aliakbarazizi:main

Conversation

@aliakbarazizi

Copy link
Copy Markdown
Contributor

Summary

Add missing props to virtual list

Changelog

[General] [Fixed] - Virtual list props

Test Plan

relative pull request in DefinitelyTyped
DefinitelyTyped/DefinitelyTyped#63323

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2022
@analysis-bot

analysis-bot commented Nov 22, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,102,588+30
androidhermesarmeabi-v7a6,470,669+36
androidhermesx867,520,065+31
androidhermesx86_647,378,750+28
androidjscarm64-v8a8,967,454+11
androidjscarmeabi-v7a7,698,320+30
androidjscx869,029,603+21
androidjscx86_649,507,453+24

Base commit: 3eb69f2
Branch: main

@analysis-bot

analysis-bot commented Nov 22, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 3eb69f2
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for 389f570 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for 389f570 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Comment threadLibraries/Lists/VirtualizedList.d.ts
Remove extra props
@pull-bot

Copy link
Copy Markdown

PR build artifact for e534fc1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for e534fc1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @aliakbarazizi in 6c33fd1.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Nov 28, 2022
cipolleschi pushed a commit that referenced this pull request Dec 19, 2022
Summary:
Add missing props to virtual list
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[General] [Fixed] - Virtual list props
Pull Request resolved: #35434
Test Plan:
relative pull request in DefinitelyTyped
DefinitelyTyped/DefinitelyTyped#63323
Reviewed By: javache
Differential Revision: D41553396
Pulled By: NickGerleman
fbshipit-source-id: d51a93410ece9ad5f0bb61e2ee51076973e80c8c
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@aliakbarazizi@analysis-bot@pull-bot@facebook-github-bot@react-native-bot@NickGerleman