Skip to content

RNGP - Correctly Support Gradle Configuration Cache - #35455

Closed
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D41519506
Closed

RNGP - Correctly Support Gradle Configuration Cache#35455
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D41519506

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:
This little change allows to support Gradle Configuration cache in user projects:
https://docs.gradle.org/current/userguide/configuration_cache.html

It allows to save several seconds on the build time.
We'll keep it disabled for now, but Gradle plans to enable it by default for everyone
in the future, so this changes makes us ready for it.

Changelog:
[Internal] [Changed] - RNGP - Correctly Support Gradle Configuration Cache

Differential Revision: D41519506

Summary:
This little change allows to support Gradle Configuration cache in user projects:
https://docs.gradle.org/current/userguide/configuration_cache.html
It allows to save several seconds on the build time.
We'll keep it disabled for now, but Gradle plans to enable it by default for everyone
in the future, so this changes makes us ready for it.
Changelog:
[Internal] [Changed] - RNGP - Correctly Support Gradle Configuration Cache
Differential Revision: D41519506
fbshipit-source-id: 0d017da59a8cbf1419207ab529b79cce8f7e0453
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 24, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41519506

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,103,571+0
androidhermesarmeabi-v7a6,471,892+0
androidhermesx867,521,209+0
androidhermesx86_647,380,086+0
androidjscarm64-v8a8,968,449+0
androidjscarmeabi-v7a7,699,552+0
androidjscx869,030,741+0
androidjscx86_649,508,784+0

Base commit: 9517320
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 9517320
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for bbd110c is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for bbd110c is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 25c97bb.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Nov 24, 2022
cortinico added a commit that referenced this pull request Nov 29, 2022
Summary:
Pull Request resolved: #35455
This little change allows to support Gradle Configuration cache in user projects:
https://docs.gradle.org/current/userguide/configuration_cache.html
It allows to save several seconds on the build time.
We'll keep it disabled for now, but Gradle plans to enable it by default for everyone
in the future, so this changes makes us ready for it.
Changelog:
[Internal] [Changed] - RNGP - Correctly Support Gradle Configuration Cache
Reviewed By: cipolleschi
Differential Revision: D41519506
fbshipit-source-id: 6252546e811deb0777c0aab5332291368be7fa8f
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cortinico@facebook-github-bot@analysis-bot@pull-bot@react-native-bot