Skip to content

Bump AGP to 7.4.x - #35456

Closed
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D41519549
Closed

Bump AGP to 7.4.x#35456
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D41519549

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:
Fixes#35439

There is a bug in AGP 7.3.x which is causing assets to don't be copied properly inside the
final artifact: issuetracker.google.com/issues/237421684
As AGP 7.4.x is really close to release (is in Beta5, should be released stable in the next weeks)
we should be fine by bumping to beta5.

This also requires a bump of RNGP

Changelog:
[Android] [Changed] - Bump AGP to 7.4.x

allow-large-files

Differential Revision: D41519549

Summary:
Fixesreact#35439
There is a bug in AGP 7.3.x which is causing assets to don't be copied properly inside the
final artifact: issuetracker.google.com/issues/237421684
As AGP 7.4.x is really close to release (is in Beta5, should be released stable in the next weeks)
we should be fine by bumping to beta5.
This also requires a bump of RNGP
Changelog:
[Android] [Changed] - Bump AGP to 7.4.x
allow-large-files
Differential Revision: D41519549
fbshipit-source-id: a64e3ef73bb0df691cf9d2cde8f340aac75ac009
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 24, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41519549

@react-native-botreact-native-bot added the Platform: Android Android applications. label Nov 24, 2022
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,103,571+0
androidhermesarmeabi-v7a6,471,892+0
androidhermesx867,521,209+0
androidhermesx86_647,380,086+0
androidjscarm64-v8a8,968,449+0
androidjscarmeabi-v7a7,699,552+0
androidjscx869,030,741+0
androidjscx86_649,508,784+0

Base commit: 9517320
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 9517320
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for 375b194 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for 375b194 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 4c5eb8d.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Nov 24, 2022
cortinico added a commit that referenced this pull request Nov 29, 2022
Summary:
Pull Request resolved: #35456Fixes#35439
There is a bug in AGP 7.3.x which is causing assets to don't be copied properly inside the
final artifact: issuetracker.google.com/issues/237421684
As AGP 7.4.x is really close to release (is in Beta5, should be released stable in the next weeks)
we should be fine by bumping to beta5.
This also requires a bump of RNGP
Changelog:
[Android] [Changed] - Bump AGP to 7.4.x
allow-large-files
Reviewed By: cipolleschi
Differential Revision: D41519549
fbshipit-source-id: 60d568a3e49798a23f1d7bf4839ab58bd5549aba
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartnerPlatform: AndroidAndroid applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static images are not rendered on Android for 0.71.0-rc.0

5 participants

@cortinico@facebook-github-bot@analysis-bot@pull-bot@react-native-bot