Skip to content

Expose hermes-executor to be consumed via prefab - #35457

Closed
cortinico wants to merge 2 commits into
react:mainfrom
cortinico:export-D41520019
Closed

Expose hermes-executor to be consumed via prefab#35457
cortinico wants to merge 2 commits into
react:mainfrom
cortinico:export-D41520019

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:
This exposes hermes-executor to be consumed via prefab so that
libraries can depend on it and use its symbols if needed (Expo and Reanimated need it).

Changelog:
[Internal] [Changed] - Expose hermes-executor to be consumed via prefab

Differential Revision: D41520019

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 24, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41520019

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,103,560-11
androidhermesarmeabi-v7a6,471,897+5
androidhermesx867,521,188-21
androidhermesx86_647,380,073-13
androidjscarm64-v8a8,968,410-39
androidjscarmeabi-v7a7,699,508-44
androidjscx869,030,692-49
androidjscx86_649,508,745-39

Base commit: 9517320
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 9517320
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for 7bd618f3a43bef198215e01ae4a916c0e612725f is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

cortinicoand others added 2 commits November 24, 2022 05:43
Summary:
Historically, we used to have hermes-executor debug and release as separate dynamic libraries.
This makes it impossible to prefab this library, so I have to reconcile it into a single library.
This will also help keep the setup consistent with the internal (BUCK) where we have a single target.
Changelog:
[Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target
Differential Revision: D41519119
fbshipit-source-id: aaecbef87e99efff6048f8b9c5ceb4c6f24f621b
Summary:
Pull Request resolved: react#35457
This exposes `hermes-executor` to be consumed via prefab so that
libraries can depend on it and use its symbols if needed (Expo and Reanimated need it).
Changelog:
[Internal] [Changed] - Expose `hermes-executor` to be consumed via prefab
Differential Revision: D41520019
fbshipit-source-id: 0fa6564b7f6fe8e01f202e8c161929df86351506
@pull-bot

Copy link
Copy Markdown

PR build artifact for 7bd618f3a43bef198215e01ae4a916c0e612725f is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41520019

@pull-bot

Copy link
Copy Markdown

PR build artifact for 0d04a4a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for 0d04a4a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

// This prefab target is used by Expo & Reanimated to load a new instance of Hermes
new PrefabPreprocessingEntry(
"hermes-executor",
// "hermes-executor" is statically linking agaisnt "hermes-executor-common"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// "hermes-executor" is statically linking agaisnt "hermes-executor-common"
// "hermes-executor" is statically linking against "hermes-executor-common"

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in b70707b.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Nov 24, 2022
cortinico added a commit that referenced this pull request Nov 29, 2022
Summary:
Pull Request resolved: #35457
This exposes `hermes-executor` to be consumed via prefab so that
libraries can depend on it and use its symbols if needed (Expo and Reanimated need it).
Changelog:
[Internal] [Changed] - Expose `hermes-executor` to be consumed via prefab
Reviewed By: cipolleschi
Differential Revision: D41520019
fbshipit-source-id: d590a043ea89fdd8ff41b0ed20900c9cf381a1e4
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@cortinico@facebook-github-bot@analysis-bot@pull-bot@react-native-bot@tomekzaw