Uh oh!
There was an error while loading. Please reload this page.
Add prefab for _uimanager _scheduler and _mounting - #35458
Closed
cortinico wants to merge 3 commits into
Closed
Conversation
Summary: Historically, we used to have hermes-executor debug and release as separate dynamic libraries. This makes it impossible to prefab this library, so I have to reconcile it into a single library. This will also help keep the setup consistent with the internal (BUCK) where we have a single target. Changelog: [Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target Differential Revision: D41519119 fbshipit-source-id: 3702d1011e46fcfdf0912d99935831789007a1b1
Summary: This exposes `hermes-executor` to be consumed via prefab so that libraries can depend on it and use its symbols if needed (Expo and Reanimated need it). Changelog: [Internal] [Changed] - Expose `hermes-executor` to be consumed via prefab Differential Revision: D41520019 fbshipit-source-id: 21e7e8d6e2183914205687bfabd827e3ccfdb530
Summary: We're adding prefab support for those modules as they're needed by Reanimated and we're exposing headers for them as well. Changelog: [Internal] [Changed] - Add prefab for _uimanager _scheduler and _mounting Reviewed By: cipolleschi Differential Revision: D41520606 fbshipit-source-id: 2224a7c268a731642d5a40d62b5d574102d627e2
facebook-github-bot
commented
Nov 24, 2022
Contributor
This pull request was exported from Phabricator. Differential Revision: D41520606 |
analysis-bot
commented
Nov 24, 2022
Base commit: 9517320 |
analysis-bot
commented
Nov 24, 2022
Base commit: 9517320 |
pull-bot
commented
Nov 24, 2022
PR build artifact for 2d1b75d is ready. |
pull-bot
commented
Nov 24, 2022
PR build artifact for 2d1b75d is ready. |
react-native-bot
commented
Nov 24, 2022
Collaborator
This pull request was successfully merged by @cortinico in 055d09c. When will my fix make it into a release? | Upcoming Releases |
cortinico added a commit
that referenced
this pull request
Nov 29, 2022
Summary: Pull Request resolved: #35458 We're adding prefab support for those modules as they're needed by Reanimated and we're exposing headers for them as well. Changelog: [Internal] [Changed] - Add prefab for _uimanager _scheduler and _mounting Reviewed By: cipolleschi Differential Revision: D41520606 fbshipit-source-id: 76f3c81705e99057b92cd9b86d0601a2b1410f95
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We're adding prefab support for those modules as they're needed by Reanimated
and we're exposing headers for them as well.
Changelog:
[Internal] [Changed] - Add prefab for _uimanager _scheduler and _mounting
Reviewed By: cipolleschi
Differential Revision: D41520606