Uh oh!
There was an error while loading. Please reload this page.
Add missing headers to react_nativemodule_core prefab module - #35460
Closed
cortinico wants to merge 4 commits into
Closed
Add missing headers to react_nativemodule_core prefab module#35460cortinico wants to merge 4 commits into
react_nativemodule_core prefab module#35460cortinico wants to merge 4 commits into
Conversation
Summary: Historically, we used to have hermes-executor debug and release as separate dynamic libraries. This makes it impossible to prefab this library, so I have to reconcile it into a single library. This will also help keep the setup consistent with the internal (BUCK) where we have a single target. Changelog: [Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target Differential Revision: D41519119 fbshipit-source-id: 62bd02e49e0f6bedc561b58e06c46fe4f45ef78f
Summary: This exposes `hermes-executor` to be consumed via prefab so that libraries can depend on it and use its symbols if needed (Expo and Reanimated need it). Changelog: [Internal] [Changed] - Expose `hermes-executor` to be consumed via prefab Differential Revision: D41520019 fbshipit-source-id: 98f93d807b5c06d14b7aae164fa969c41bb3fcc8
Summary: We're adding prefab support for those modules as they're needed by Reanimated and we're exposing headers for them as well. Changelog: [Internal] [Changed] - Add prefab for _uimanager _scheduler and _mounting Differential Revision: D41520606 fbshipit-source-id: be505959f0b919596f3280b1344188f678eb31e3
Summary: Reanimated reported that `react_nativemodule_core` was missing some headers. Specifically the one from ReactAndroid::react_debug, ReactAndroid::react_render_core, ReactAndroid::glog, and ReactAndroid::react_render_debug. I'm adding them here so they get included in the shipped headers for `react_nativemodule_core` Changelog: [Internal] [Changed] - Add missing headers to `react_nativemodule_core` prefab module Reviewed By: cipolleschi Differential Revision: D41520751 fbshipit-source-id: b11f83fc0146148373f0b99e2f2a22cbf2d82d3c
facebook-github-bot
commented
Nov 24, 2022
Contributor
This pull request was exported from Phabricator. Differential Revision: D41520751 |
analysis-bot
commented
Nov 24, 2022
Base commit: 9517320 |
analysis-bot
commented
Nov 24, 2022
Base commit: 9517320 |
pull-bot
commented
Nov 24, 2022
PR build artifact for bd9c72c is ready. |
pull-bot
commented
Nov 24, 2022
PR build artifact for bd9c72c is ready. |
react-native-bot
commented
Nov 24, 2022
Collaborator
This pull request was successfully merged by @cortinico in 3328221. When will my fix make it into a release? | Upcoming Releases |
cortinico added a commit
that referenced
this pull request
Nov 29, 2022
Summary: Pull Request resolved: #35460 Reanimated reported that `react_nativemodule_core` was missing some headers. Specifically the one from ReactAndroid::react_debug, ReactAndroid::react_render_core, ReactAndroid::glog, and ReactAndroid::react_render_debug. I'm adding them here so they get included in the shipped headers for `react_nativemodule_core` Changelog: [Internal] [Changed] - Add missing headers to `react_nativemodule_core` prefab module Reviewed By: cipolleschi Differential Revision: D41520751 fbshipit-source-id: 4627a2d0f880d4bb3ff2f0e43cd735cf9a3f2f9a
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reanimated reported that
react_nativemodule_corewas missing some headers.Specifically the one from ReactAndroid::react_debug, ReactAndroid::react_render_core, ReactAndroid::glog,
and ReactAndroid::react_render_debug.
I'm adding them here so they get included in the shipped headers for
react_nativemodule_coreChangelog:
[Internal] [Changed] - Add missing headers to
react_nativemodule_coreprefab moduleReviewed By: cipolleschi
Differential Revision: D41520751