Uh oh!
There was an error while loading. Please reload this page.
fix: update CircleCI config to use the RN version in tarball caching - #35471
Closed
cipolleschi wants to merge 1 commit into
Closed
fix: update CircleCI config to use the RN version in tarball caching#35471cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
cipolleschiforce-pushed
the
cipolleschi/fix_hermes_tarball_name
branch
2 times, most recently
from
November 25, 2022 09:37
aa5cff6 to
70fb416Compare
Base commit: c4959b9 |
Base commit: c4959b9 |
cipolleschi
marked this pull request as ready for review
November 25, 2022 11:29
facebook-github-bot
commented
Nov 25, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschiforce-pushed
the
cipolleschi/fix_hermes_tarball_name
branch
from
November 25, 2022 11:45
70fb416 to
e146aedComparefacebook-github-bot
commented
Nov 25, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kelset
approved these changes
Nov 25, 2022
kelset
left a comment
Contributor
There was a problem hiding this comment.
LGTM but I guess we'll only be able to verify it actually works when we release the next RC 😅
react-native-bot
commented
Nov 25, 2022
Collaborator
This pull request was successfully merged by @cipolleschi in 319631f. When will my fix make it into a release? | Upcoming Releases |
kelset pushed a commit
that referenced
this pull request
Nov 30, 2022
…35471) Summary: This PR updates the Cache strategy for the tarballs to include the React Native version we are building. In this way, when we publish a new Release/RC we are sure that we are going to rebuild a nmew tarball. This should fix caching problems like: - we have misconfigured the build script for the Hermes tarball, we then fix it, but we distribute the wrong cached artifacts - the cached artifact has the wrong version ## Changelog [Internal] - Fixed Hermes Tarball Cache Logic Pull Request resolved: #35471 Test Plan: 1. CircleCI The real way to check this is in the next RC cycle or in the next nightly. Reviewed By: cortinico Differential Revision: D41530651 Pulled By: cipolleschi fbshipit-source-id: 45e8fd3b62c8e108d393d9463ff6762dfc6d3ec8
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Cache strategy for the tarballs to include the React Native version we are building. In this way, when we publish a new Release/RC we are sure that we are going to rebuild a nmew
tarball. This should fix caching problems like:
Changelog
[Internal] - Fixed Hermes Tarball Cache Logic
Test Plan
The real way to check this is in the next RC cycle or in the next nightly.