Uh oh!
There was an error while loading. Please reload this page.
[RN][iOS] Do not add LongLivedObject wrapper in OSS - #35491
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Base commit: 10a8f18 |
cipolleschi
marked this pull request as ready for review
November 28, 2022 11:36
facebook-github-bot
commented
Nov 28, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
commented
Nov 28, 2022
ContributorAuthor
Closing this as I'm working on a Stack internally to fix |
facebook-github-bot pushed a commit
that referenced
this pull request
Nov 29, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: #35491 Test Plan: 1. Manually tested in an app from RC2 Reviewed By: cortinico Differential Revision: D41548985 Pulled By: cipolleschi fbshipit-source-id: acc57fccdedb344a3aa105f2968645a049392e07
react-native-bot
commented
Nov 29, 2022
Collaborator
This pull request was successfully merged by @cipolleschi in dd0bf83. When will my fix make it into a release? | Upcoming Releases |
kelset pushed a commit
that referenced
this pull request
Nov 30, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: #35491 Test Plan: 1. Manually tested in an app from RC2 Reviewed By: cortinico Differential Revision: D41548985 Pulled By: cipolleschi fbshipit-source-id: acc57fccdedb344a3aa105f2968645a049392e07
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change excludes the
LongLivedObject.hfile from the pod in the ReactCommon library.The file creates a problem when the
use_frameworks!option is used in an app because there can't be two files with the same name, despite being in different paths,within the same framework. Specifically, this
LongLivedObjectis just a redirect to the other one, so it should be safe to exclude this.Changelog
[iOS][Fixed] - Exclude redirector to
LongLivedObject.hfrom ReactCommon podspecTest Plan