Skip to content

Don't use the internal native_modules.rb script yet - #35531

Closed
tido64 wants to merge 1 commit into
mainfrom
tido/fix-template-0.71
Closed

Don't use the internal native_modules.rb script yet#35531
tido64 wants to merge 1 commit into
mainfrom
tido/fix-template-0.71

Conversation

@tido64

@tido64tido64 commented Dec 1, 2022

Copy link
Copy Markdown
Collaborator

Summary

Revert the template Podfile to using @react-native-community/cli-platform-ios/native_modules. The new internal script currently has a hard-coded path to @react-native-community/cli-platform-ios which may not work in monorepos. The path in the Podfile is also hard-coded, but this is a file that the user has access to and can fix themselves if necessary.

Changelog

[iOS] [Fixed] - Don't use the internal native_modules.rb script yet, as it hides a hard-coded path

Test Plan

n/a

@tido64
tido64 requested a review from cortinicoDecember 1, 2022 19:11
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Dec 1, 2022
@cortinico

Copy link
Copy Markdown
Contributor

I'll leave to @kelset to merge this

@tido64
tido64 changed the base branch from 0.71-stable to mainDecember 2, 2022 09:55
@tido64
tido64 removed the request for review from mhorowitzDecember 2, 2022 09:57
@tido64
tido64force-pushed the tido/fix-template-0.71 branch from 9cb8978 to 76dd07bCompareDecember 2, 2022 09:57
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 759056b
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,102,194+0
androidhermesarmeabi-v7a6,470,977+0
androidhermesx867,520,401+0
androidhermesx86_647,378,759+0
androidjscarm64-v8a8,969,947+0
androidjscarmeabi-v7a7,701,347+0
androidjscx869,032,663+0
androidjscx86_649,510,145+0

Base commit: 759056b
Branch: main

@github-actions

Copy link
Copy Markdown

This pull request was successfully merged by @tido64 in 4df793f.

When will my fix make it into a release? | Upcoming Releases

@github-actionsgithub-actionsBot added the Merged This PR has been merged. label Dec 2, 2022
@kelset
kelset deleted the tido/fix-template-0.71 branch December 2, 2022 12:20
kelset pushed a commit that referenced this pull request Dec 13, 2022
Summary:
Revert the template `Podfile` to using `react-native-community/cli-platform-ios/native_modules`. The new internal script currently has a hard-coded path to `react-native-community/cli-platform-ios` which may not work in monorepos. The path in the `Podfile` is also hard-coded, but this is a file that the user has access to and can fix themselves if necessary.
## Changelog
[iOS] [Fixed] - Don't use the internal `native_modules.rb` script yet, as it hides a hard-coded path
Pull Request resolved: #35531
Test Plan: n/a
Reviewed By: rshest
Differential Revision: D41682119
Pulled By: cortinico
fbshipit-source-id: 1822fcd20a794dc9df6e8d6f36615e90b42c1a94
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.p: MicrosoftPartner: MicrosoftPartnerPlatform: iOSiOS applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tido64@cortinico@facebook-github-bot@analysis-bot@react-native-bot