Uh oh!
There was an error while loading. Please reload this page.
De-bump AGP to 7.3.1 and do not use addGeneratedSourceDirectory - #35631
Closed
cortinico wants to merge 1 commit into
Closed
De-bump AGP to 7.3.1 and do not use addGeneratedSourceDirectory#35631cortinico wants to merge 1 commit into
addGeneratedSourceDirectory#35631cortinico wants to merge 1 commit into
Conversation
Summary: Fixesreact#35592 I'm de-bumping AGP from 7.4 to 7.3 as per react#35592. There is no stable release of AGP that is working fine with the `addGeneratedSourceDirectory` API for resources. Here I'm reverting to use the older APIs. Changelog: [Internal] [Changed] - De-bump AGP to 7.3.1 and do not use `addGeneratedSourceDirectory` Differential Revision: D42004813 fbshipit-source-id: d35bcb0b5d9d9b2c6b096d5566d2d6f2187d836e
facebook-github-bot
commented
Dec 13, 2022
Contributor
This pull request was exported from Phabricator. Differential Revision: D42004813 |
analysis-bot
commented
Dec 13, 2022
Base commit: 455ca8c |
analysis-bot
commented
Dec 13, 2022
Base commit: 455ca8c |
pull-bot
commented
Dec 13, 2022
PR build artifact for a95e5a3 is ready. |
pull-bot
commented
Dec 13, 2022
PR build artifact for a95e5a3 is ready. |
facebook-github-bot
commented
Dec 14, 2022
Contributor
This pull request has been merged in 46ffeca. |
cipolleschi pushed a commit
that referenced
this pull request
Dec 19, 2022
…5631) Summary: Pull Request resolved: #35631Fixes#35592 I'm de-bumping AGP from 7.4 to 7.3 as per #35592. There is no stable release of AGP that is working fine with the `addGeneratedSourceDirectory` API for resources. Here I'm reverting to use the older APIs. Changelog: [Internal] [Changed] - De-bump AGP to 7.3.1 and do not use `addGeneratedSourceDirectory` allow-large-files Reviewed By: cipolleschi Differential Revision: D42004813 fbshipit-source-id: f1a2b0f7c2233402749a3e4f3828be80111ad3a7
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes#35592
I'm de-bumping AGP from 7.4 to 7.3 as per #35592. There is no stable release
of AGP that is working fine with the
addGeneratedSourceDirectoryAPI for resources.Here I'm reverting to use the older APIs.
Changelog:
[Internal] [Changed] - De-bump AGP to 7.3.1 and do not use
addGeneratedSourceDirectoryDifferential Revision: D42004813