Skip to content

[RN][iOS] Automatically detect when use frameworks is used - #35636

Closed
cipolleschi wants to merge 1 commit into
mainfrom
feat/detect_use_frameworks
Closed

[RN][iOS] Automatically detect when use frameworks is used#35636
cipolleschi wants to merge 1 commit into
mainfrom
feat/detect_use_frameworks

Conversation

@cipolleschi

@cipolleschicipolleschi commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

Summary

This PR introduce an automatic way to detect whether the user sets its podfile to use frameworks.
In this way, users don't have to install pods with a specific environment flag but they can rely on the standard Cocoapods usage

Changelog

[IOS][ADDED] - Automatically detect whether use_frameworks! is used

Test Plan

  • CircleCI is Green
  • Added unit tests
  • Tested locally with an app

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 14, 2022
@facebook-github-bot

facebook-github-bot commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi

cipolleschi commented Dec 14, 2022

Copy link
Copy Markdown
ContributorAuthor

@Kudo@mikehardy I would really appreciate your review on this PR! 🙏

@analysis-bot

analysis-bot commented Dec 14, 2022•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 03b17d9
Branch: main

Kudo
Kudo reviewed Dec 14, 2022
View reviewed changes

@KudoKudo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr. i'm leaving some comments and hopefully to be helpful.

Comment threadscripts/cocoapods/utils.rb

Pod::UI.puts("Framework build type is #{framework_build_type}")

if framework_build_type === "static framework"

@KudoKudoDec 14, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great for pasting the code reference, e.g. https://github.com/CocoaPods/Core/blob/c6ac388ee43f0782fdb8e32386f41f96dbe29082/lib/cocoapods-core/build_type.rb#L104-L106

@cipolleschicipolleschiDec 14, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add all the references!

Comment threadscripts/react_native_pods.rb
@cipolleschi

cipolleschi commented Dec 16, 2022

Copy link
Copy Markdown
ContributorAuthor

/rebase

@github-actions
github-actionsBotforce-pushed the feat/detect_use_frameworks branch from 10a319a to 41958d5CompareDecember 16, 2022 10:09
@analysis-bot

analysis-bot commented Dec 16, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,468,287+0
androidhermesarmeabi-v7a7,787,988+0
androidhermesx868,943,399+0
androidhermesx86_648,800,531+0
androidjscarm64-v8a9,659,502+0
androidjscarmeabi-v7a8,392,616+0
androidjscx869,723,515+0
androidjscx86_6410,201,030+0

Base commit: 03b17d9
Branch: main

@facebook-github-bot

facebook-github-bot commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Dec 16, 2022
@facebook-github-bot

facebook-github-bot commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

@cipolleschi merged this pull request in f249bee.

cipolleschi pushed a commit that referenced this pull request Dec 19, 2022
Riccardo Cipolleschi
Automatically detect when use frameworks is used (#35636)
f7b35c0
Summary:
This PR introduce an automatic way to detect whether the user sets its podfile to use frameworks.
In this way, users don't have to install pods with a specific environment flag but they can rely on the standard Cocoapods usage
## Changelog
[IOS][ADDED] - Automatically detect whether use_frameworks! is used
Pull Request resolved: #35636
Test Plan:
- CircleCI is Green
- Added unit tests
- Tested locally with an app
Reviewed By: dmytrorykun
Differential Revision: D42029355
Pulled By: cipolleschi
fbshipit-source-id: 76c92133deabbda59603b043a4d542737f10f044
@NOUIYNOUIY mentioned this pull request Feb 3, 2023
Open
@cipolleschi
cipolleschi deleted the feat/detect_use_frameworks branch March 27, 2023 13:26
@cipolleschicipolleschi mentioned this pull request Aug 16, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Nov 1, 2023
Merged
This was referenced Jan 8, 2024
Merged
Merged
@cipolleschicipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschicipolleschi mentioned this pull request Apr 5, 2024
Closed
@cipolleschicipolleschi mentioned this pull request Apr 26, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@KudoKudoKudo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cipolleschi@facebook-github-bot@analysis-bot@Kudo