Skip to content

Expose react_render_animations via prefab. - #35643

Closed
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D42033642
Closed

Expose react_render_animations via prefab.#35643
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D42033642

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:
The react_render_animations was not exposed via prefab. I'm adding it to make possible for
Reanimated to integrate on top of us via prefab.
Ref reactwg/react-native-releases#41 (reply in thread)

Changelog:
[Internal] [Changed] - Expose react_render_animations via prefab.

Differential Revision: D42033642

Summary:
The `react_render_animations` was not exposed via prefab. I'm adding it to make possible for
Reanimated to integrate on top of us via prefab.
Ref reactwg/react-native-releases#41 (reply in thread)
Changelog:
[Internal] [Changed] - Expose `react_render_animations` via prefab.
Differential Revision: D42033642
fbshipit-source-id: ef7cb7360e299292c2894cccb32b919679658aa9
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 14, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D42033642

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,464,867+0
androidhermesarmeabi-v7a7,784,482+0
androidhermesx868,939,275+0
androidhermesx86_648,797,363+0
androidjscarm64-v8a9,657,526+0
androidjscarmeabi-v7a8,390,394+0
androidjscx869,721,241+0
androidjscx86_6410,198,762+0

Base commit: 46ffeca
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 46ffeca
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for 5e9674e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for 5e9674e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 52f4ff7.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Dec 14, 2022
cipolleschi pushed a commit that referenced this pull request Dec 19, 2022
Summary:
Pull Request resolved: #35643
The `react_render_animations` was not exposed via prefab. I'm adding it to make possible for
Reanimated to integrate on top of us via prefab.
Ref reactwg/react-native-releases#41 (reply in thread)
Changelog:
[Internal] [Changed] - Expose `react_render_animations` via prefab.
Reviewed By: cipolleschi
Differential Revision: D42033642
fbshipit-source-id: da4b3665f4fb1c7f8266fa6896585176504435c3
@tomekzawtomekzaw mentioned this pull request Feb 15, 2023
facebook-github-bot pushed a commit that referenced this pull request Feb 15, 2023
Summary:
The `rrc_root` was not exposed via prefab. I'm adding it to make possible for Reanimated to integrate on top of React Native via prefab. Based on #35643.
## Changelog
[ANDROID] [CHANGED] - Expose `rrc_root` via prefab.
Pull Request resolved: #36166
Reviewed By: cipolleschi
Differential Revision: D43304302
Pulled By: cortinico
fbshipit-source-id: 1c4a7013a33b48a8a7a445a78430630542420f4d
kelset pushed a commit that referenced this pull request Mar 6, 2023
Summary:
The `rrc_root` was not exposed via prefab. I'm adding it to make possible for Reanimated to integrate on top of React Native via prefab. Based on #35643.
## Changelog
[ANDROID] [CHANGED] - Expose `rrc_root` via prefab.
Pull Request resolved: #36166
Reviewed By: cipolleschi
Differential Revision: D43304302
Pulled By: cortinico
fbshipit-source-id: 1c4a7013a33b48a8a7a445a78430630542420f4d
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cortinico@facebook-github-bot@analysis-bot@pull-bot