Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary repositories{} block from top level build.gradle - #35644
Closed
cortinico wants to merge 1 commit into
Closed
Remove unnecessary repositories{} block from top level build.gradle#35644cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary:
The `repositories{}` block in the top level build.gradle is not needed anymore
The React Native Gradle Plugin is taking care of it.
Users can still specify if they need to provide custom repositories.
Changelog:
[Android] [Changed] - Remove unnecessary repositories{} block from top level build.gradle
Reviewed By: cipolleschi
Differential Revision: D42033953
fbshipit-source-id: d4069bad84310df20bb344f8190eb7d6bbb67524facebook-github-bot
commented
Dec 14, 2022
Contributor
This pull request was exported from Phabricator. Differential Revision: D42033953 |
analysis-bot
commented
Dec 14, 2022
Base commit: 46ffeca |
pull-bot
commented
Dec 14, 2022
PR build artifact for 4143491 is ready. |
analysis-bot
commented
Dec 14, 2022
Base commit: 46ffeca |
pull-bot
commented
Dec 14, 2022
PR build artifact for 4143491 is ready. |
facebook-github-bot
commented
Dec 14, 2022
Contributor
This pull request has been merged in 51a48d2. |
cipolleschi pushed a commit
that referenced
this pull request
Dec 19, 2022
…35644) Summary: Pull Request resolved: #35644 The `repositories{}` block in the top level build.gradle is not needed anymore The React Native Gradle Plugin is taking care of it. Users can still specify if they need to provide custom repositories. Changelog: [Android] [Changed] - Remove unnecessary repositories{} block from top level build.gradle Reviewed By: cipolleschi Differential Revision: D42033953 fbshipit-source-id: 8ec1c12147fae68302ab47c60045869c72d1812c
4 tasks
Merged
This was referenced Jan 8, 2024
3 tasks
gabrieldonadel added a commit
to expo/expo
that referenced
this pull request
Aug 20, 2025
…9010) # Why We no longer need to set `url(reactNativeAndroidDir)` on the template because this is now handled by the React Native Gradle Plugin. This was removed from react native's template on 0.71 (react/react-native#35644) but we never removed it from ours # How Remove unnecessary react-native repositories from `build.gradle` # Test Plan Run BareExpo and PaperTester locally # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Eric-Tyrrell22 pushed a commit
to Eric-Tyrrell22/expo
that referenced
this pull request
Sep 5, 2025
…po#39010) # Why We no longer need to set `url(reactNativeAndroidDir)` on the template because this is now handled by the React Native Gradle Plugin. This was removed from react native's template on 0.71 (react/react-native#35644) but we never removed it from ours # How Remove unnecessary react-native repositories from `build.gradle` # Test Plan Run BareExpo and PaperTester locally # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
repositories{}block in the top level build.gradle is not needed anymoreThe React Native Gradle Plugin is taking care of it.
Users can still specify if they need to provide custom repositories.
Changelog:
[Android] [Changed] - Remove unnecessary repositories{} block from top level build.gradle
Reviewed By: cipolleschi
Differential Revision: D42033953