Skip to content

Fix prefab prefix for fabricjni - #35648

Closed
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D42047434
Closed

Fix prefab prefix for fabricjni#35648
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D42047434

Conversation

@cortinico

@cortinicocortinico commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

Summary:
The fabricjni prefab module was missing the react/fabric prefix.
I'm adding it here.
Ref: reactwg/react-native-releases#41 (reply in thread)

Changelog:
[Internal] [Changed] - Fix prefab prefix for fabricjni

Differential Revision: D42047434

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 14, 2022
@facebook-github-bot

facebook-github-bot commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D42047434

@analysis-bot

analysis-bot commented Dec 14, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 5663671
Branch: main

@pull-bot

pull-bot commented Dec 14, 2022

Copy link
Copy Markdown

PR build artifact for 1a0d7d21bb7923cbf8e723d08fc3102be9b55df2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

pull-bot commented Dec 14, 2022

Copy link
Copy Markdown

PR build artifact for 1a0d7d21bb7923cbf8e723d08fc3102be9b55df2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@cortinico@facebook-github-bot
Fix prefab prefix for fabricjni (react#35648)
7ac8fa9
Summary:
Pull Request resolved: react#35648
The `fabricjni` prefab module was missing the `react/fabric` prefix.
I'm adding it here.
Ref: reactwg/react-native-releases#41 (reply in thread)
Changelog:
[Internal] [Changed] - Fix prefab prefix for fabricjni
Differential Revision: D42047434
fbshipit-source-id: 30396145a0a9854feec00a2cdf9dcb1225ccd41d
@facebook-github-bot

facebook-github-bot commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D42047434

@analysis-bot

analysis-bot commented Dec 14, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,464,867+0
androidhermesarmeabi-v7a7,784,482+0
androidhermesx868,939,275+0
androidhermesx86_648,797,363+0
androidjscarm64-v8a9,657,526+0
androidjscarmeabi-v7a8,390,394+0
androidjscx869,721,241+0
androidjscx86_6410,198,762+0

Base commit: 5663671
Branch: main

@pull-bot

pull-bot commented Dec 14, 2022

Copy link
Copy Markdown

PR build artifact for 7ac8fa9 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

pull-bot commented Dec 14, 2022

Copy link
Copy Markdown

PR build artifact for 7ac8fa9 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot

facebook-github-bot commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

This pull request has been merged in 3487640.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Dec 15, 2022
cipolleschi pushed a commit that referenced this pull request Dec 19, 2022
@cortinicoRiccardo Cipolleschi
Fix prefab prefix for fabricjni (#35648)
621d901
Summary:
Pull Request resolved: #35648
The `fabricjni` prefab module was missing the `react/fabric` prefix.
I'm adding it here.
Ref: reactwg/react-native-releases#41 (reply in thread)
Changelog:
[Internal] [Changed] - Fix prefab prefix for fabricjni
Reviewed By: cipolleschi
Differential Revision: D42047434
fbshipit-source-id: 202db49cd1ada2462652dbd7e56bad6779c263ac
@cipolleschicipolleschi mentioned this pull request Aug 16, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Nov 1, 2023
Merged
This was referenced Jan 8, 2024
Merged
Merged
@cipolleschicipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschicipolleschi mentioned this pull request Apr 5, 2024
Closed
@cipolleschicipolleschi mentioned this pull request Apr 26, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cortinico@facebook-github-bot@analysis-bot@pull-bot