Uh oh!
There was an error while loading. Please reload this page.
Add compiler flag for the new Arch when enabled. - #35672
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Summary: While working on some example, I discovered that the helper function `install_module_dependencies` was not adding the proper `-DRCT_NEW_ARCH_ENABLED=1` flag to the compiler flags. ## Changelog: [iOS][Fixed] - Make sure to add the New Arch flag to libraries Differential Revision: D42131287 fbshipit-source-id: f6eb077b38c3e55af75ef771a1aa09ca2f498cdc
facebook-github-bot
commented
Dec 18, 2022
Contributor
This pull request was exported from Phabricator. Differential Revision: D42131287 |
analysis-bot
commented
Dec 18, 2022
Base commit: 76a1445 |
analysis-bot
commented
Dec 18, 2022
Base commit: 76a1445 |
pull-bot
commented
Dec 18, 2022
PR build artifact for 972d6a6 is ready. |
pull-bot
commented
Dec 18, 2022
PR build artifact for 972d6a6 is ready. |
facebook-github-bot
commented
Dec 19, 2022
Contributor
This pull request has been merged in ef11e15. |
cipolleschi added a commit
that referenced
this pull request
Dec 19, 2022
Summary: Pull Request resolved: #35672 While working on some example, I discovered that the helper function `install_module_dependencies` was not adding the proper `-DRCT_NEW_ARCH_ENABLED=1` flag to the compiler flags. ## Changelog: [iOS][Fixed] - Make sure to add the New Arch flag to libraries Reviewed By: jacdebug Differential Revision: D42131287 fbshipit-source-id: 68c492150ba4e4a2ec726b3e8b8a9c7842b543bc
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While working on some example, I discovered that the helper function
install_module_dependencieswas not adding the proper-DRCT_NEW_ARCH_ENABLED=1flag to the compiler flags.Changelog:
[iOS][Fixed] - Make sure to add the New Arch flag to libraries
Differential Revision: D42131287