fix: fix the potential race condition when dismissing and presentating modal

[wood1986]

Summary

react-native-screens has a bug about UIViewControllerHierarchyInconsistency when dismissing a react-native<Modal>. Here is the bug software-mansion/react-native-screens#944

After adding dispatch_async block, it solves the issue. But I do not know if this is the right fix.

Here is the example repo https://github.com/wood1986/react-native-modal-crash.

You can revert my last commit wood1986/react-native-modal-crash@86e7bc1 to reproduce the issue. (after revert or hard reset, you need to rerun git clean -xfdq and yarn install)

Changelog

[IOS] [FIXED] - fixed the potential race condition when dismissing and presentating modal

Test Plan

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,467,354	+0
android	hermes	armeabi-v7a	7,787,208	+0
android	hermes	x86	8,942,212	+0
android	hermes	x86_64	8,799,859	+0
android	jsc	arm64-v8a	9,652,983	+0
android	jsc	armeabi-v7a	8,386,725	+0
android	jsc	x86	9,716,974	+0
android	jsc	x86_64	10,194,432	+0

Base commit: 9669c10
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 9669c10
Branch: main

[pull-bot]

PR build artifact for 4414f1e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[facebook-github-bot]

@makovkastar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@makovkastar merged this pull request in e948c79.