Uh oh!
There was an error while loading. Please reload this page.
fix: use properly exclude parameter of matrix - #35794
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
cipolleschiforce-pushed
the
test/circle-ci-matrixes
branch
from
January 12, 2023 10:55
2f5c1b9 to
397f274Comparefacebook-github-bot
commented
Jan 12, 2023
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 91397d4 |
cipolleschiforce-pushed
the
test/circle-ci-matrixes
branch
from
January 12, 2023 12:12
397f274 to
8fe9a0dCompare
cipolleschiforce-pushed
the
test/circle-ci-matrixes
branch
from
January 12, 2023 12:14
8fe9a0d to
9d02f28Comparefacebook-github-bot
commented
Jan 12, 2023
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Jan 12, 2023
Contributor
@cipolleschi merged this pull request in 4c5fa6e. |
kelset pushed a commit
that referenced
this pull request
Jan 30, 2023
Summary: Update the CircleCI configuration to use the proper `exclude` parameter of matrix rather then bootstrap a machine and then kill it. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> ## Changelog [Internal] - Use the `exclude` parameter of matrices to avoid spinning up unnecessary machines Pull Request resolved: #35794 Test Plan: The number of jobs on CircleCI should decrease. Reviewed By: dmytrorykun Differential Revision: D42475445 Pulled By: cipolleschi fbshipit-source-id: 3d733ac459a3bc9747440a62cb2caecb7a235fec
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the CircleCI configuration to use the proper
excludeparameter of matrix rather then bootstrap a machine and then kill it.Changelog
Changelog
[Internal] - Use the
excludeparameter of matrices to avoid spinning up unnecessary machinesTest Plan
The number of jobs on CircleCI should decrease.