fix(scripts): add logic for version scripts to account for local E2E test versioning

[kelset]

Summary

While working on 0.71 branch I encountered a problem in testing locally. Basically, I was getting hit by a silent error caused by recent work #35296 that didn't account for the shape of E2E local script for the release, 0.71.0-20230116-1649.

This scripts fixes both aspects: the error now gets thrown "better" and the logic accounts for the E2E shape.

Changelog

[INTERNAL] [FIXED] - add logic for version scripts to account for local E2E test versioning

Test Plan

Tested via the other PR: #35847

[cipolleschi]

I left a suggestion for better error messaging plus a question.

The rest of the scripts looks good to me!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,464,873	-660
android	hermes	armeabi-v7a	7,785,604	-676
android	hermes	x86	8,938,342	-671
android	hermes	x86_64	8,796,410	-673
android	jsc	arm64-v8a	9,651,262	+608
android	jsc	armeabi-v7a	8,385,729	+600
android	jsc	x86	9,713,458	+611
android	jsc	x86_64	10,190,641	+610

Base commit: e6d1ab9
Branch: main

[cipolleschi]

There are a couple of linting issues, could you take care of them, please? 🙏

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[kelset]

There are a couple of linting issues, could you take care of them, please? 🙏

we really need to get this folder properly typed 😥

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

Effectively, @cortinico noticed that this should be the default behavior... @kelset do you think we can remove this try-catch?

[kelset]

during my testing, adding this seemed to have an effect so that exec() would catch the error correctly. I can remove but honestly, what's the problem with having it?

[facebook-github-bot]

@cipolleschi merged this pull request in f238f15.