Uh oh!
There was an error while loading. Please reload this page.
RNGP - Honor the --active-arch-only when configuring the NDK - #35860
Closed
cortinico wants to merge 1 commit into
Closed
RNGP - Honor the --active-arch-only when configuring the NDK#35860cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary: I've just realized that the `--active-arch-only` is not correctly passed down to RNGP to set up an abiFilter so users on 0.71 on New Architecture end up building all the architectures even if `--active-arch-only` is set. This fix makes sure the `abiFilters` is applied if the user specified either the `--active-arch-only`, the `reactNativeArchitectures` property and is not using the Split ABI feature. Changelog: [Android] [Fixed] - RNGP - Honor the --active-arch-only when configuring the NDK Differential Revision: D42547987 fbshipit-source-id: f1170101b206aa5a0d32582c6950761f9e7dee37
facebook-github-bot
commented
Jan 17, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D42547987 |
analysis-bot
commented
Jan 17, 2023
Base commit: 8ea1cba |
facebook-github-bot
commented
Jan 18, 2023
Contributor
This pull request has been merged in 470f79b. |
kelset pushed a commit
that referenced
this pull request
Jan 19, 2023
Summary: Pull Request resolved: #35860 I've just realized that the `--active-arch-only` is not correctly passed down to RNGP to set up an abiFilter so users on 0.71 on New Architecture end up building all the architectures even if `--active-arch-only` is set. This fix makes sure the `abiFilters` is applied if the user specified either the `--active-arch-only`, the `reactNativeArchitectures` property and is not using the Split ABI feature. Changelog: [Android] [Fixed] - RNGP - Honor the --active-arch-only when configuring the NDK Reviewed By: cipolleschi Differential Revision: D42547987 fbshipit-source-id: 5a34e7087bb4f89de74cc52f9c505e36896fbf03
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I've just realized that the
--active-arch-onlyis not correctly passed downto RNGP to set up an abiFilter so users on 0.71 on New Architecture end up
building all the architectures even if
--active-arch-onlyis set.This fix makes sure the
abiFiltersis applied if the user specifiedeither the
--active-arch-only, thereactNativeArchitecturespropertyand is not using the Split ABI feature.
Changelog:
[Android] [Fixed] - RNGP - Honor the --active-arch-only when configuring the NDK
Differential Revision: D42547987