Uh oh!
There was an error while loading. Please reload this page.
fix: ReactRootView checkForKeyboardEvents to check if rootInsets are set - #35869
Closed
enahum wants to merge 1 commit into
Closed
fix: ReactRootView checkForKeyboardEvents to check if rootInsets are set#35869enahum wants to merge 1 commit into
enahum wants to merge 1 commit into
Conversation
analysis-bot
commented
Jan 18, 2023
Base commit: f4072b1 |
cortinico
approved these changes
Jan 18, 2023
facebook-github-bot
commented
Jan 18, 2023
Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Jan 19, 2023
Contributor
@cortinico merged this pull request in 4cdc2c4. |
cipolleschi pushed a commit
that referenced
this pull request
Jan 19, 2023
…set (#35869) Summary: react-native-navigation allows to register React components to be included in the navigation top bar as buttons, the way this work is by using the AppRegistry. When the ViewTreeObserver executes the `CustomGlobalLayout` we are checking for the RootWindowInsets in the `checkKeyboardEvents` which in the case for the top bar component it returns null and the **WindowInsetsCompat.toWindowInsetsCompat** function throws if the insets are null causing the app to crash. Interestingly in the function `checkForKeyboardEventsLegacy` the null value is being checked, so I guess it was overlooked in the newer function. ## Changelog [ANDROID] [FIXED] - Fix ReactRootView crash when root view window insets are null Pull Request resolved: #35869 Test Plan: The following videos show how the app crashes as soon as we attempt to pop a screen that contains a react component as a button in the navigation top bar and how it correctly pops to the previous screen after applying the fix | Crash | Fix | | -- | -- | | https://user-images.githubusercontent.com/6757047/213116971-fe693989-f978-438c-b8f9-fc56f2a477c8.mp4 | https://user-images.githubusercontent.com/6757047/213118352-fe258f28-07aa-4d17-98d2-97136464ffd5.mp4 | Reviewed By: cipolleschi Differential Revision: D42580156 Pulled By: cortinico fbshipit-source-id: 4dbd656d7c8148df67668a2a50913206bc35c07f
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-native-navigation allows to register React components to be included in the navigation top bar as buttons, the way this work is by using the AppRegistry. When the ViewTreeObserver executes the
CustomGlobalLayoutwe are checking for the RootWindowInsets in thecheckKeyboardEventswhich in the case for the top bar component it returns null and the WindowInsetsCompat.toWindowInsetsCompat function throws if the insets are null causing the app to crash.Interestingly in the function
checkForKeyboardEventsLegacythe null value is being checked, so I guess it was overlooked in the newer function.Changelog
[ANDROID] [FIXED] - Fix ReactRootView crash when root view window insets are null
Test Plan
The following videos show how the app crashes as soon as we attempt to pop a screen that contains a react component as a button in the navigation top bar and how it correctly pops to the previous screen after applying the fix