Uh oh!
There was an error while loading. Please reload this page.
Fix for resources not correctly bundlded on release appbundles - #35872
Closed
cortinico wants to merge 1 commit into
Closed
Fix for resources not correctly bundlded on release appbundles#35872cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary: When downgrading from AGP 7.4 to 7.3 we were forced to resort to older APIs to bundle resources. It seems like we haven't properly wired the task to make sure resources generated by Metro are correctly accounted before the generation of release app bundles/apks. This fixes it. This fix can also be removed once we are on AGP 7.4 Fixesreact#35865 Changelog: [Android] [Fixed] - Fix for resources not correctly bundlded on release appbundles Differential Revision: D42573450 fbshipit-source-id: f3f3ed228788e9c406e066b63e70f20fd0f4daeb
facebook-github-bot
commented
Jan 18, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D42573450 |
kelset
approved these changes
Jan 18, 2023
analysis-bot
commented
Jan 18, 2023
Base commit: 473eb1d |
facebook-github-bot
commented
Jan 18, 2023
Contributor
This pull request has been merged in 60b9d8c. |
kelset pushed a commit
that referenced
this pull request
Jan 19, 2023
Summary: Pull Request resolved: #35872 When downgrading from AGP 7.4 to 7.3 we were forced to resort to older APIs to bundle resources. It seems like we haven't properly wired the task to make sure resources generated by Metro are correctly accounted before the generation of release app bundles/apks. This fixes it. This fix can also be removed once we are on AGP 7.4 Fixes#35865 Changelog: [Android] [Fixed] - Fix for resources not correctly bundlded on release appbundles Reviewed By: cipolleschi Differential Revision: D42573450 fbshipit-source-id: a810924315f72e02e4c988ae86112bf0a06a9ce5
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When downgrading from AGP 7.4 to 7.3 we were forced to resort to older APIs
to bundle resources. It seems like we haven't properly wired the task to make sure
resources generated by Metro are correctly accounted before the generation of
release app bundles/apks.
This fixes it. This fix can also be removed once we are on AGP 7.4
Fixes#35865
Changelog:
[Android] [Fixed] - Fix for resources not correctly bundlded on release appbundles
Differential Revision: D42573450