Uh oh!
There was an error while loading. Please reload this page.
Fix TurboModuleRegistry TS type - #35885
Closed
janicduplessis wants to merge 2 commits into
Closed
Conversation
analysis-bot
commented
Jan 19, 2023
Base commit: 0c150b2 |
Contributor
LGTM for importing TurboModuleRegistry from its path, though for most cases you should probably prefer using the public export for this instead of reaching into a file inside the package. I know there are places where our own documentation doesn't do this though. |
NickGerleman
commented
Jan 19, 2023
Contributor
I.e. prefer "import {TurboModuleRegistry} from 'react-native'" |
facebook-github-bot
commented
Jan 19, 2023
Contributor
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Jan 19, 2023
Contributor
@NickGerleman merged this pull request in c289442. |
ContributorAuthor
Yea I realized after working on this that it is also a public export from react-native. |
kelset pushed a commit
that referenced
this pull request
Jan 30, 2023
Summary: TurboModuleRegistry export functions and not a TurboModuleRegistry object. See https://github.com/facebook/react-native/blob/main/Libraries/TurboModule/TurboModuleRegistry.js#L37 ## Changelog [GENERAL] [FIXED] - Fix TurboModuleRegistry TS type Pull Request resolved: #35885 Test Plan: Tested that the import doesn't generate a type error when used correctly. ```ts import * as TurboModuleRegistry from 'react-native/Libraries/TurboModule/TurboModuleRegistry'; export default TurboModuleRegistry.get<Spec>('RNCSafeAreaContext'); ``` Reviewed By: christophpurrer Differential Revision: D42604208 Pulled By: NickGerleman fbshipit-source-id: e6259df24aaf6e37b32cc4b51947294fd655837e
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TurboModuleRegistry export functions and not a TurboModuleRegistry object. See https://github.com/facebook/react-native/blob/main/Libraries/TurboModule/TurboModuleRegistry.js#L37
Changelog
[GENERAL] [FIXED] - Fix TurboModuleRegistry TS type
Test Plan
Tested that the import doesn't generate a type error when used correctly.