Skip to content

feat: Add logical border block color properties - #35999

Closed
gabrieldonadel wants to merge 6 commits into
react:mainfrom
gabrieldonadel:feat/add-logical-border-color
Closed

feat: Add logical border block color properties #35999
gabrieldonadel wants to merge 6 commits into
react:mainfrom
gabrieldonadel:feat/add-logical-border-color

Conversation

@gabrieldonadel

Copy link
Copy Markdown
Collaborator

Summary

This PR implements logical border block color properties as requested on #34425. This implementation includes the addition of the following style properties

  • borderBlockColor, equivalent to borderTopColor and borderBottomColor.
  • borderBlockEndColor, equivalent to borderBottomColor.
  • borderBlockStartColor, equivalent to borderTopColor.

Changelog

[GENERAL] [ADDED] - Add logical border block color properties

Test Plan

  1. Open the RNTester app and navigate to the View page
  2. Test the new style properties through the Logical Border Color section
AndroidiOS
Screen.Recording.2023-01-30.at.01.01.44.mov
Screen.Recording.2023-01-30.at.02.12.26.mov

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2023
@analysis-bot

analysis-bot commented Jan 30, 2023

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,463,812+264
androidhermesarmeabi-v7a7,785,331+1,368
androidhermesx868,937,786+1,164
androidhermesx86_648,796,110+1,449
androidjscarm64-v8a9,649,403+444
androidjscarmeabi-v7a8,384,789+1,563
androidjscx869,712,279+1,356
androidjscx86_6410,189,428+1,651

Base commit: 83743e1
Branch: main

Comment threadReact/Views/RCTView.h
Comment on lines +104 to +106
@property (nonatomic, assign) CGFloat borderBlockWidth;
@property (nonatomic, assign) CGFloat borderBlockEndWidth;
@property (nonatomic, assign) CGFloat borderBlockStartWidth;

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put up a follow-up PR implementing this but this is necessary here due to RCT_VIEW_BORDER_PROPERTY which creates set functions for both border##SIDE##Color and border##SIDE##Width

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Jan 31, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@jacdebug merged this pull request in 597a1ff.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gabrieldonadel@analysis-bot@facebook-github-bot