Uh oh!
There was an error while loading. Please reload this page.
Add Tests in CircleCI to check dynamic frameworks with the old arch - #36003
Closed
cipolleschi wants to merge 3 commits into
Closed
Add Tests in CircleCI to check dynamic frameworks with the old arch#36003cipolleschi wants to merge 3 commits into
cipolleschi wants to merge 3 commits into
Conversation
Summary: I discovered that 0.69 and 0.70 could run React Native as Dynamic framework with JSC and starting from 0.71 that's not possible anymore. This diff restore that possibility. ## Changelog [iOS][Fixed] - Add Back dynamic framework support for the old architecture Differential Revision: D42829137 fbshipit-source-id: 191591e85ecc5a2e509d283c52a18ab00b4319a5
Summary: I discovered that 0.69 could run React Native as Dynamic framework with Hermes and starting from 0.70 that's not possible anymore. This diff restore that possibility. Notice that now Hermes provisdes JSI and Dynamic Frameworks requires that all the dependencies are explicitly defined, therefore, whenever we have a pod that depended on `React-jsi`, now it also has to explicitly depends on `hermes-engine` ## Changelog [iOS][Fixed] - Add Back dynamic framework support for the Old Architecture with Hermes Differential Revision: https://internalfb.com/D42829728 fbshipit-source-id: 107b524e833db1cd81a8821adff1143ffc758afa
Summary: This diff adds 4 tests in CircleCI to make sure we don't regress in the support of Dynamic Frameworks for the old architecture. ## Changelog [iOS][Fixed] - Add CircleCI tests for dynamic frameworks with the Old Architecture. Differential Revision: D42829895 fbshipit-source-id: 4d1983356f53942b1804c89628877d9e0ec04b08
facebook-github-bot
commented
Jan 30, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D42829895 |
analysis-bot
commented
Jan 30, 2023
Base commit: 8d5f880 |
cortinico
approved these changes
Jan 30, 2023
facebook-github-bot
commented
Jan 30, 2023
Contributor
This pull request has been merged in 8056cd7. |
kelset pushed a commit
that referenced
this pull request
Jan 30, 2023
…36003) Summary: Pull Request resolved: #36003 This diff adds 4 tests in CircleCI to make sure we don't regress in the support of Dynamic Frameworks for the old architecture. ## Changelog [iOS][Fixed] - Add CircleCI tests for dynamic frameworks with the Old Architecture. Reviewed By: cortinico Differential Revision: D42829895 fbshipit-source-id: 5669be45d4f55161a11a6ece161b2a2aa384a644
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds 4 tests in CircleCI to make sure we don't regress in the support of Dynamic Frameworks for the old architecture.
Changelog
[iOS][Fixed] - Add CircleCI tests for dynamic frameworks with the Old Architecture.
Differential Revision: D42829895