Skip to content

[IOS] Add smartInsertDelete prop to TextInput component - #36111

Closed
fabioh8010 wants to merge 3 commits into
react:mainfrom
fabioh8010:feature/text-input-ios-autoformatting-behaviors
Closed

[IOS] Add smartInsertDelete prop to TextInput component#36111
fabioh8010 wants to merge 3 commits into
react:mainfrom
fabioh8010:feature/text-input-ios-autoformatting-behaviors

Conversation

@fabioh8010

@fabioh8010fabioh8010 commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Summary:

This PR add support to configure the smartInsertDeleteType property in iOS inputs as described here, making possible toggle this autoformatting behavior.

PR for the docs update: react/react-native-website#3560

Changelog:

[IOS] [ADDED] - Add smartInsertDelete prop to TextInput component

Test Plan:

  • Added an example in the RNTester app to test this behavior in iOS.
  • If the smartInsertDelete prop is true or undefined, the system will use the default autoformatting behavior.
  • If the smartInsertDelete prop is false, the system will disable the autoformatting behavior.
Simulator.Screen.Recording.-.iPhone.14.-.2023-02-09.at.15.40.07.mp4

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 9, 2023
@analysis-bot

analysis-bot commented Feb 9, 2023

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,744,424+0
androidhermesarmeabi-v7a8,056,632+1
androidhermesx869,235,553+1
androidhermesx86_649,086,370-11
androidjscarm64-v8a9,307,282+16
androidjscarmeabi-v7a8,496,823+10
androidjscx869,369,291+7
androidjscx86_649,624,213+8

Base commit: e449706
Branch: main

@mountiny

Copy link
Copy Markdown

Nice improvement! 😍

@ArjunSharda

Copy link
Copy Markdown

Great!

@NickGerleman

Copy link
Copy Markdown
Contributor

@fabioh8010 could you rebase?

@fabioh8010
fabioh8010force-pushed the feature/text-input-ios-autoformatting-behaviors branch from afb2f95 to 8fc4331CompareJune 7, 2023 15:04
@fabioh8010

Copy link
Copy Markdown
ContributorAuthor

@NickGerleman done!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Jun 8, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@NickGerleman merged this pull request in 6b62f12.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@fabioh8010@analysis-bot@mountiny@ArjunSharda@NickGerleman@facebook-github-bot