fix: border rendering problem in Android

[BeeMargarida]

Summary

Fixes#36036

The problem was in ReactViewBackgroundDrawable.java that was not accounting for adjacent borders that add width set to 0.

Changelog

[Android] [Fixed] - Fix border rendering issue when bottom borders has no width

Test Plan

Previously	Now with the fix

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,479,906	+140
android	hermes	armeabi-v7a	7,800,769	+145
android	hermes	x86	8,955,600	+138
android	hermes	x86_64	8,813,441	+150
android	jsc	arm64-v8a	9,117,152	+186
android	jsc	armeabi-v7a	8,313,222	+184
android	jsc	x86	9,168,554	+185
android	jsc	x86_64	9,427,379	+176

Base commit: 96df8c0
Branch: main

[facebook-github-bot]

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

/rebase

[javache]

Could you explain why don't need this logic for mInnerTopLeftCorner and mInnerTopRightCorner?

[BeeMargarida]

Yes, it can be added (my bad, I kinda had tunnel vision). In the cases where this bug happened it won't cause any difference though, because mInnerClipTempRectForBorderRadius.top was always 0. Do you want me to make a commit adding the same logic to mInnerTopLeftCorner and mInnerTopRightCorner?

[javache]

If it doesn't make a difference, we shouldn't add it. So you're saying we don't need similar logic for the top corners?

[BeeMargarida]

I'm not totally sure. From what I saw from the code, mInnerClipTempRectForBorderRadius is set based on the getBounds of the drawable. In cases where the bounds don't change, top will always be 0. Is there any possibility of the bounds changing in this case?

Update: ah, there is if we change the size of drawable...I'll test it (nvm, not the case, from what I can tell top will always remain 0)

[javache]

Looks like this logic was changed not too long ago in #34362. It seems there was no test-case added at that time, can you verify this doesn't regress it?

[BeeMargarida]

Looks like this logic was changed not too long ago in #34362. It seems there was no test-case added at that time, can you verify this doesn't regress it?

Seems like there is no regression 👍

[facebook-github-bot]

@javache merged this pull request in 1d51032.

[zbranevichfinstek]

@javache Please add this to 0.71

[javache]

@zbranevichfinstek: please raise this in the 0.71 release thread - https://github.com/reactwg/react-native-releases/discussions

[lanphammm]

I don't want to upgrade the react native version, so is there any way to fix this issue?
I have tried editing file ReactViewBackgroundDrawable.java inside node_modules but it's failed.

Dependencies: {
"react": "18.2.0",
"react-native": "0.71.3"
}