Skip to content

Add option to commit with generic message - #36421

Closed
hoxyq wants to merge 1 commit into
react:mainfrom
hoxyq:export-D43943526
Closed

Add option to commit with generic message#36421
hoxyq wants to merge 1 commit into
react:mainfrom
hoxyq:export-D43943526

Conversation

@hoxyq

@hoxyqhoxyq commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Summary:
Changelog: [Internal]

Adding an extra choice for commit question, user can now choose between three options:

  1. Commit with generic message, no further actions needed
  2. Commit with custom message, intercative VIM input will open
  3. Not committing anything

Differential Revision: D43943526

Summary:
Changelog: [Internal]
Adding an extra choice for commit question, user can now choose between three options:
1. Commit with generic message, no further actions needed
2. Commit with custom message, intercative VIM input will open
3. Not committing anything
Differential Revision: D43943526
fbshipit-source-id: 8c3462434ff7057923d80d17e6402610f4ef8794
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 9, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D43943526

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,515,397+0
androidhermesarmeabi-v7a7,831,285+0
androidhermesx868,995,721+0
androidhermesx86_648,851,197+0
androidjscarm64-v8a9,140,029+0
androidjscarmeabi-v7a8,331,628+0
androidjscx869,194,989+0
androidjscx86_649,453,096+0

Base commit: bcec590
Branch: main

@hoxyq
hoxyq requested a review from kelsetMarch 9, 2023 14:40

@kelsetkelset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Mar 9, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 8d8b44a.

kelset pushed a commit that referenced this pull request Mar 28, 2023
Summary:
Pull Request resolved: #36421
Changelog: [Internal]
Adding an extra choice for commit question, user can now choose between three options:
1. Commit with generic message, no further actions needed
2. Commit with custom message, intercative VIM input will open
3. Not committing anything
Reviewed By: cortinico
Differential Revision: D43943526
fbshipit-source-id: 014215105d192961486b7d1c697f491697492812
@cipolleschicipolleschi mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@facebook-github-bot@analysis-bot@kelset