Skip to content

RN [refactor]: bump and realign package versions by running a single … - #36573

Merged
hoxyq merged 1 commit into
react:0.72-stablefrom
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Mar 31, 2023
Merged

RN [refactor]: bump and realign package versions by running a single …#36573
hoxyq merged 1 commit into
react:0.72-stablefrom
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable

Conversation

@hoxyq

@hoxyqhoxyq commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

See #36568

Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly

@hoxyq
hoxyq requested a review from kelsetMarch 22, 2023 15:21
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 22, 2023
@github-actions

github-actionsBot commented Mar 22, 2023•
edited
Loading

Copy link
Copy Markdown
Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927

@analysis-bot

analysis-bot commented Mar 22, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,543,017-25,396
androidhermesarmeabi-v7a7,858,618-24,169
androidhermesx869,023,421-26,898
androidhermesx86_648,878,520-26,844
androidjscarm64-v8a9,142,999-24,008
androidjscarmeabi-v7a8,334,663-22,741
androidjscx869,198,157-25,517
androidjscx86_649,456,010-25,528

Base commit: 606946d
Branch: main

Ruslan Lesiutin@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927
…script
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq
hoxyqforce-pushed the hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable branch from 1d377e2 to a469927CompareMarch 31, 2023 12:45
@hoxyq
hoxyq merged commit 68cd44b into react:0.72-stableMar 31, 2023
@hoxyq
hoxyq deleted the hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable branch March 31, 2023 14:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@kelsetkelsetAwaiting requested review from kelset

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@analysis-bot@cortinico@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
RN [refactor]: bump and realign package versions by running a single … by hoxyq · Pull Request #36573 · react/react-native · GitHub
Skip to content
RN [refactor]: bump and realign package versions by running a single … - #36573
Merged
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Mar 31, 2023
Merged
RN [refactor]: bump and realign package versions by running a single …#36573
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Conversation
@hoxyq
@hoxyqhoxyq
commented
Mar 22, 2023

Copy link


Copy Markdown

Contributor
See #36568
Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly
@hoxyq
hoxyq
requested a review
from kelsetMarch 22, 2023 15:21
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 22, 2023
@github-actions
github-actionsBot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

Fails
🚫
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927
@analysis-bot
analysis-bot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,543,017-25,396
androidhermesarmeabi-v7a7,858,618-24,169
androidhermesx869,023,421-26,898
androidhermesx86_648,878,520-26,844
androidjscarm64-v8a9,142,999-24,008
androidjscarmeabi-v7a8,334,663-22,741
androidjscx869,198,157-25,517
androidjscx86_649,456,010-25,528
Base commit: 606946d

Branch: main
Ruslan Lesiutin@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927
…script
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq
hoxyqforce-pushed
the
hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
branch
from
1d377e2 to
a469927CompareMarch 31, 2023 12:45
@hoxyq
hoxyq
merged commit 68cd44b
into
react:0.72-stableMar 31, 2023
@hoxyq
hoxyq
deleted the

hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable

branch
March 31, 2023 14:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@kelsetkelsetAwaiting requested review from kelset

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@analysis-bot@cortinico@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
RN [refactor]: bump and realign package versions by running a single … by hoxyq · Pull Request #36573 · react/react-native · GitHub
Skip to content
RN [refactor]: bump and realign package versions by running a single … - #36573
Merged
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Mar 31, 2023
Merged
RN [refactor]: bump and realign package versions by running a single …#36573
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Conversation
@hoxyq
@hoxyqhoxyq
commented
Mar 22, 2023

Copy link


Copy Markdown

Contributor
See #36568
Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly
@hoxyq
hoxyq
requested a review
from kelsetMarch 22, 2023 15:21
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 22, 2023
@github-actions
github-actionsBot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

Fails
🚫
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927
@analysis-bot
analysis-bot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,543,017-25,396
androidhermesarmeabi-v7a7,858,618-24,169
androidhermesx869,023,421-26,898
androidhermesx86_648,878,520-26,844
androidjscarm64-v8a9,142,999-24,008
androidjscarmeabi-v7a8,334,663-22,741
androidjscx869,198,157-25,517
androidjscx86_649,456,010-25,528
Base commit: 606946d

Branch: main
Ruslan Lesiutin@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927
…script
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq
hoxyqforce-pushed
the
hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
branch
from
1d377e2 to
a469927CompareMarch 31, 2023 12:45
@hoxyq
hoxyq
merged commit 68cd44b
into
react:0.72-stableMar 31, 2023
@hoxyq
hoxyq
deleted the

hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable

branch
March 31, 2023 14:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@kelsetkelsetAwaiting requested review from kelset

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@analysis-bot@cortinico@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
RN [refactor]: bump and realign package versions by running a single … by hoxyq · Pull Request #36573 · react/react-native · GitHub
Skip to content
RN [refactor]: bump and realign package versions by running a single … - #36573
Merged
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Mar 31, 2023
Merged
RN [refactor]: bump and realign package versions by running a single …#36573
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Conversation
@hoxyq
@hoxyqhoxyq
commented
Mar 22, 2023

Copy link


Copy Markdown

Contributor
See #36568
Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly
@hoxyq
hoxyq
requested a review
from kelsetMarch 22, 2023 15:21
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 22, 2023
@github-actions
github-actionsBot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

Fails
🚫
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927
@analysis-bot
analysis-bot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,543,017-25,396
androidhermesarmeabi-v7a7,858,618-24,169
androidhermesx869,023,421-26,898
androidhermesx86_648,878,520-26,844
androidjscarm64-v8a9,142,999-24,008
androidjscarmeabi-v7a8,334,663-22,741
androidjscx869,198,157-25,517
androidjscx86_649,456,010-25,528
Base commit: 606946d

Branch: main
Ruslan Lesiutin@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927
…script
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq
hoxyqforce-pushed
the
hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
branch
from
1d377e2 to
a469927CompareMarch 31, 2023 12:45
@hoxyq
hoxyq
merged commit 68cd44b
into
react:0.72-stableMar 31, 2023
@hoxyq
hoxyq
deleted the

hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable

branch
March 31, 2023 14:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@kelsetkelsetAwaiting requested review from kelset

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@analysis-bot@cortinico@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
RN [refactor]: bump and realign package versions by running a single … by hoxyq · Pull Request #36573 · react/react-native · GitHub
Skip to content
RN [refactor]: bump and realign package versions by running a single … - #36573
Merged
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Mar 31, 2023
Merged
RN [refactor]: bump and realign package versions by running a single …#36573
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Conversation
@hoxyq
@hoxyqhoxyq
commented
Mar 22, 2023

Copy link


Copy Markdown

Contributor
See #36568
Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly
@hoxyq
hoxyq
requested a review
from kelsetMarch 22, 2023 15:21
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 22, 2023
@github-actions
github-actionsBot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

Fails
🚫
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927
@analysis-bot
analysis-bot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,543,017-25,396
androidhermesarmeabi-v7a7,858,618-24,169
androidhermesx869,023,421-26,898
androidhermesx86_648,878,520-26,844
androidjscarm64-v8a9,142,999-24,008
androidjscarmeabi-v7a8,334,663-22,741
androidjscx869,198,157-25,517
androidjscx86_649,456,010-25,528
Base commit: 606946d

Branch: main
Ruslan Lesiutin@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927
…script
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq
hoxyqforce-pushed
the
hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
branch
from
1d377e2 to
a469927CompareMarch 31, 2023 12:45
@hoxyq
hoxyq
merged commit 68cd44b
into
react:0.72-stableMar 31, 2023
@hoxyq
hoxyq
deleted the

hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable

branch
March 31, 2023 14:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@kelsetkelsetAwaiting requested review from kelset

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@analysis-bot@cortinico@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
RN [refactor]: bump and realign package versions by running a single … by hoxyq · Pull Request #36573 · react/react-native · GitHub
Skip to content
RN [refactor]: bump and realign package versions by running a single … - #36573
Merged
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Mar 31, 2023
Merged
RN [refactor]: bump and realign package versions by running a single …#36573
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Conversation
@hoxyq
@hoxyqhoxyq
commented
Mar 22, 2023

Copy link


Copy Markdown

Contributor
See #36568
Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly
@hoxyq
hoxyq
requested a review
from kelsetMarch 22, 2023 15:21
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 22, 2023
@github-actions
github-actionsBot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

Fails
🚫
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927
@analysis-bot
analysis-bot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,543,017-25,396
androidhermesarmeabi-v7a7,858,618-24,169
androidhermesx869,023,421-26,898
androidhermesx86_648,878,520-26,844
androidjscarm64-v8a9,142,999-24,008
androidjscarmeabi-v7a8,334,663-22,741
androidjscx869,198,157-25,517
androidjscx86_649,456,010-25,528
Base commit: 606946d

Branch: main
Ruslan Lesiutin@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927
…script
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq
hoxyqforce-pushed
the
hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
branch
from
1d377e2 to
a469927CompareMarch 31, 2023 12:45
@hoxyq
hoxyq
merged commit 68cd44b
into
react:0.72-stableMar 31, 2023
@hoxyq
hoxyq
deleted the

hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable

branch
March 31, 2023 14:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@kelsetkelsetAwaiting requested review from kelset

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@analysis-bot@cortinico@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
RN [refactor]: bump and realign package versions by running a single … by hoxyq · Pull Request #36573 · react/react-native · GitHub
Skip to content
RN [refactor]: bump and realign package versions by running a single … - #36573
Merged
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Mar 31, 2023
Merged
RN [refactor]: bump and realign package versions by running a single …#36573
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Conversation
@hoxyq
@hoxyqhoxyq
commented
Mar 22, 2023

Copy link


Copy Markdown

Contributor
See #36568
Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly
@hoxyq
hoxyq
requested a review
from kelsetMarch 22, 2023 15:21
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 22, 2023
@github-actions
github-actionsBot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

Fails
🚫
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927
@analysis-bot
analysis-bot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,543,017-25,396
androidhermesarmeabi-v7a7,858,618-24,169
androidhermesx869,023,421-26,898
androidhermesx86_648,878,520-26,844
androidjscarm64-v8a9,142,999-24,008
androidjscarmeabi-v7a8,334,663-22,741
androidjscx869,198,157-25,517
androidjscx86_649,456,010-25,528
Base commit: 606946d

Branch: main
Ruslan Lesiutin@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927
…script
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq
hoxyqforce-pushed
the
hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
branch
from
1d377e2 to
a469927CompareMarch 31, 2023 12:45
@hoxyq
hoxyq
merged commit 68cd44b
into
react:0.72-stableMar 31, 2023
@hoxyq
hoxyq
deleted the

hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable

branch
March 31, 2023 14:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@kelsetkelsetAwaiting requested review from kelset

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@analysis-bot@cortinico@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
RN [refactor]: bump and realign package versions by running a single … by hoxyq · Pull Request #36573 · react/react-native · GitHub
Skip to content
RN [refactor]: bump and realign package versions by running a single … - #36573
Merged
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Mar 31, 2023
Merged
RN [refactor]: bump and realign package versions by running a single …#36573
hoxyq merged 1 commit into
react:0.72-stablefrom 
hoxyq:hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
Conversation
@hoxyq
@hoxyqhoxyq
commented
Mar 22, 2023

Copy link


Copy Markdown

Contributor
See #36568
Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly
@hoxyq
hoxyq
requested a review
from kelsetMarch 22, 2023 15:21
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 22, 2023
@github-actions
github-actionsBot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

Fails
🚫
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927
@analysis-bot
analysis-bot
commented
Mar 22, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,543,017-25,396
androidhermesarmeabi-v7a7,858,618-24,169
androidhermesx869,023,421-26,898
androidhermesx86_648,878,520-26,844
androidjscarm64-v8a9,142,999-24,008
androidjscarmeabi-v7a8,334,663-22,741
androidjscx869,198,157-25,517
androidjscx86_649,456,010-25,528
Base commit: 606946d

Branch: main
Ruslan Lesiutin@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927
…script
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq
hoxyqforce-pushed
the
hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable
branch
from
1d377e2 to
a469927CompareMarch 31, 2023 12:45
@hoxyq
hoxyq
merged commit 68cd44b
into
react:0.72-stableMar 31, 2023
@hoxyq
hoxyq
deleted the

hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable

branch
March 31, 2023 14:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@kelsetkelsetAwaiting requested review from kelset

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hoxyq@analysis-bot@cortinico@facebook-github-bot